[improve][cli] PIP-343: Refactor pulsar-perf to subcommand #22388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodece PTAL. |
nodece
requested changes
Apr 5, 2024
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PulsarPerfTestTool.java
Show resolved
Hide resolved
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PulsarPerfTestTool.java
Show resolved
Hide resolved
pulsar-testclient/src/main/java/org/apache/pulsar/proxy/socket/client/PerformanceClient.java
Outdated
Show resolved
Hide resolved
pulsar-testclient/src/main/java/org/apache/pulsar/proxy/socket/client/PerformanceClient.java
Outdated
Show resolved
Hide resolved
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/CmdGenerateDocumentation.java
Show resolved
Hide resolved
…/client/PerformanceClient.java Co-authored-by: Zixuan Liu <[email protected]>
nodece
requested changes
Apr 15, 2024
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/ManagedLedgerWriter.java
Outdated
Show resolved
Hide resolved
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceBaseArguments.java
Show resolved
Hide resolved
nodece
reviewed
Apr 15, 2024
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PulsarPerfTestTool.java
Outdated
Show resolved
Hide resolved
|
This PR is a bit large and not easy to review. We may need to review multiple times to reach an agreement, thanks. |
Yes, most of them are some template type modifications, which require more patience to do code review. |
nodece
reviewed
Apr 17, 2024
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PulsarPerfTestTool.java
Outdated
Show resolved
Hide resolved
nodece
approved these changes
Apr 17, 2024
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
) Co-authored-by: Zixuan Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP: #22181
Improve CLI:
pulsar-perfuser experience.Motivation
Refactor
pulsar-perfto subcommand.Modifications
PulsarPerfTestToolpulsar-perfandpulsar-perf.cmdVerifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: crossoverJie#22