Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] Run Trivy image scanner with the current image #22386

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Mar 29, 2024

Motivation

Build the Docker image, so that we scan the image from master branch and we can see the latest state of sec issues

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@merlimat merlimat added this to the 3.3.0 milestone Mar 29, 2024
@merlimat merlimat requested review from lhotari and onobc March 29, 2024 21:45
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 29, 2024
onobc
onobc previously requested changes Mar 30, 2024
Copy link
Contributor

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense @merlimat - good to see the updates on the workflow. Thanks.

A tiny nit suggestion and a question around the ALL severity. But other than that - LGTM.

@merlimat merlimat requested review from lhotari and onobc April 17, 2024 22:27
@merlimat merlimat self-assigned this Apr 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.80%. Comparing base (bbc6224) to head (745340f).
Report is 599 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22386      +/-   ##
============================================
+ Coverage     73.57%   73.80%   +0.23%     
- Complexity    32624    32964     +340     
============================================
  Files          1877     1885       +8     
  Lines        139502   140129     +627     
  Branches      15299    15372      +73     
============================================
+ Hits         102638   103423     +785     
+ Misses        28908    28692     -216     
- Partials       7956     8014      +58     
Flag Coverage Δ
inttests 26.94% <ø> (+2.35%) ⬆️
systests 24.48% <ø> (+0.15%) ⬆️
unittests 73.07% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 242 files with indirect coverage changes

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari dismissed onobc’s stale review April 18, 2024 19:33

Outdated review

@lhotari lhotari merged commit 7acbc4c into apache:master Apr 18, 2024
50 of 51 checks passed
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants