-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve] Run Trivy image scanner with the current image #22386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense @merlimat - good to see the updates on the workflow. Thanks.
A tiny nit suggestion and a question around the ALL
severity. But other than that - LGTM.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22386 +/- ##
============================================
+ Coverage 73.57% 73.80% +0.23%
- Complexity 32624 32964 +340
============================================
Files 1877 1885 +8
Lines 139502 140129 +627
Branches 15299 15372 +73
============================================
+ Hits 102638 103423 +785
+ Misses 28908 28692 -216
- Partials 7956 8014 +58
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
Build the Docker image, so that we scan the image from
master
branch and we can see the latest state of sec issuesModifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: