Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Fix OpReadEntry.skipCondition NPE issue #22367

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

Technoboy-
Copy link
Contributor

Fixes #22365

Motivation

Introduced by #19035

Modifications

  • Move skipCondition = null before recyclerHandle.recycle(this);

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Technoboy- Technoboy- self-assigned this Mar 27, 2024
@Technoboy- Technoboy- added this to the 3.3.0 milestone Mar 27, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 27, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch!

@lhotari lhotari merged commit 404c057 into apache:master Mar 27, 2024
52 of 54 checks passed
lhotari pushed a commit that referenced this pull request Mar 27, 2024
lhotari pushed a commit that referenced this pull request Mar 27, 2024
Technoboy- added a commit to Technoboy-/pulsar that referenced this pull request Apr 1, 2024
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 15, 2024
(cherry picked from commit 404c057)
(cherry picked from commit bab60b1)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 17, 2024
(cherry picked from commit 404c057)
(cherry picked from commit bab60b1)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 17, 2024
(cherry picked from commit 404c057)
(cherry picked from commit bab60b1)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 19, 2024
(cherry picked from commit 404c057)
(cherry picked from commit bab60b1)
eolivelli pushed a commit that referenced this pull request Apr 21, 2024
@eolivelli
Copy link
Contributor

I have cherry-picked to branch-3.1

eolivelli pushed a commit to datastax/pulsar that referenced this pull request Apr 21, 2024
eolivelli pushed a commit to datastax/pulsar that referenced this pull request Apr 21, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment