-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Fix OpReadEntry.skipCondition NPE issue #22367
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good catch!
lhotari
pushed a commit
that referenced
this pull request
Mar 27, 2024
(cherry picked from commit 404c057)
lhotari
pushed a commit
that referenced
this pull request
Mar 27, 2024
(cherry picked from commit 404c057)
Technoboy-
added a commit
to Technoboy-/pulsar
that referenced
this pull request
Apr 1, 2024
eolivelli
pushed a commit
that referenced
this pull request
Apr 21, 2024
(cherry picked from commit 404c057)
I have cherry-picked to branch-3.1 |
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 21, 2024
(cherry picked from commit 404c057)
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 21, 2024
(cherry picked from commit 404c057)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.1
cherry-picked/branch-3.2
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.4
release/3.1.4
release/3.2.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22365
Motivation
Introduced by #19035
Modifications
skipCondition = null
beforerecyclerHandle.recycle(this);
Documentation
doc
doc-required
doc-not-needed
doc-complete