[fix][ml] No rollover inactive ledgers when metadata service invalid #22284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22284 +/- ##
============================================
+ Coverage 73.57% 73.73% +0.15%
+ Complexity 32624 32297 -327
============================================
Files 1877 1885 +8
Lines 139502 139867 +365
Branches 15299 15320 +21
============================================
+ Hits 102638 103129 +491
+ Misses 28908 28796 -112
+ Partials 7956 7942 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Mar 19, 2024
hanmz
approved these changes
Mar 19, 2024
poorbarcode
reviewed
Mar 20, 2024
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
Show resolved
Hide resolved
AnonHxy
changed the title
AnonHxy
force-pushed
the
fix_ledger_rollover
branch
from
b15f7c7 to
71fec57
Compare
|
/pulsarbot run-failure-checks |
lhotari
added
release/3.2.3
release/3.0.5
and removed
release/3.0.4
release/3.2.2
labels
dao-jun
approved these changes
Mar 29, 2024
AnonHxy
force-pushed
the
fix_ledger_rollover
branch
from
71fec57 to
2cf7ad7
Compare
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Apr 1, 2024
…pache#22284) ### Motivation We should not rollover inactive ledgers when metadata service is invailable. ### Modifications Checking metadata service is vailable when schedule `checkInactiveLedgerAndRollOver`
Technoboy-
pushed a commit
that referenced
this pull request
Apr 3, 2024
…22284) ### Motivation We should not rollover inactive ledgers when metadata service is invailable. ### Modifications Checking metadata service is vailable when schedule `checkInactiveLedgerAndRollOver`
Technoboy-
pushed a commit
that referenced
this pull request
Apr 8, 2024
…22284) ### Motivation We should not rollover inactive ledgers when metadata service is invailable. ### Modifications Checking metadata service is vailable when schedule `checkInactiveLedgerAndRollOver`
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 15, 2024
…pache#22284) ### Motivation We should not rollover inactive ledgers when metadata service is invailable. ### Modifications Checking metadata service is vailable when schedule `checkInactiveLedgerAndRollOver` (cherry picked from commit b9bf0a8)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…pache#22284) ### Motivation We should not rollover inactive ledgers when metadata service is invailable. ### Modifications Checking metadata service is vailable when schedule `checkInactiveLedgerAndRollOver` (cherry picked from commit b9bf0a8)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…pache#22284) ### Motivation We should not rollover inactive ledgers when metadata service is invailable. ### Modifications Checking metadata service is vailable when schedule `checkInactiveLedgerAndRollOver` (cherry picked from commit b9bf0a8)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 19, 2024
…pache#22284) ### Motivation We should not rollover inactive ledgers when metadata service is invailable. ### Modifications Checking metadata service is vailable when schedule `checkInactiveLedgerAndRollOver` (cherry picked from commit b9bf0a8)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2024
…pache#22284) ### Motivation We should not rollover inactive ledgers when metadata service is invailable. ### Modifications Checking metadata service is vailable when schedule `checkInactiveLedgerAndRollOver` (cherry picked from commit b9bf0a8)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…pache#22284) ### Motivation We should not rollover inactive ledgers when metadata service is invailable. ### Modifications Checking metadata service is vailable when schedule `checkInactiveLedgerAndRollOver`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should not rollover inactive ledgers when metadata service is invailable.
Modifications
Checking metadata service is vailable when schedule
checkInactiveLedgerAndRollOverVerifying this change
org.apache.bookkeeper.mledger.impl.ManagedLedgerTest#testDontRollOverInactiveLedgersWhenMetadataServiceInvalidDocumentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository:
AnonHxy#49