[improve][test] Don't configure Mockito spying for MultiBrokerTestZKBaseTest #22250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22239
Motivation
The AdvertisedListenersMultiBrokerLeaderElectionTest test is flaky since it times out.
I profiled the test with Async Profiler on Linux by adding this to pom.xml in
<test.additional.args>
and converting the
.jfr
file to.html
withjava -jar tools/async-profiler-3.0-macos/lib/converter.jar jfr2flame profile2024-03-12T10:44:25Z_1.jfr output.html
andjava -jar tools/async-profiler-3.0-macos/lib/converter.jar jfr2flame --threads profile2024-03-12T10:44:25Z_1.jfr output_threads.html
.In the profile, I could see that Mockito was causing a lot of overhead to the execution.
Modifications
.spyNoneByDefault()
toPulsarTestContext.Builder
Documentation
doc
doc-required
doc-not-needed
doc-complete