[improve][broker] Add logs to getInternalStats for quickly locate problem when schema ledger is lost
#22233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanmz
changed the title
getInternalStats for quickly locate problemgetInternalStats for quickly locate problem when schema ledger is lost
Jason918
approved these changes
Mar 11, 2024
dao-jun
approved these changes
Mar 11, 2024
hanmz
added a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…roblem when schema ledger is lost (apache#22233)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If schema ledger is lost, when we call the admin interface "topics stats-internal", the server only has the following error log:
However, this log does not clearly indicate which ledger is lost. We don’t even know whether the ledger of topic, cursor or schema is lost. Therefore, it brings challenges to quickly locate the problem.
Modifications
When failed to get ledger metadata for the schema ledger, add logs to quickly locate problem:
log.info("[{}] Failed to get ledger metadata for the schema ledger {}", topic, ledgerId, e);At this time, we can see the following log, and we can quickly and clearly know that the problem is caused by schema ledger is lost.
Documentation
docdoc-requireddoc-not-neededdoc-complete