-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug][fn] Prevent putstate
uses empty values
#22127
Merged
Technoboy-
merged 9 commits into
apache:master
from
freeznet:freeznet/validate-sts-bytes
Feb 27, 2024
Merged
[bug][fn] Prevent putstate
uses empty values
#22127
Technoboy-
merged 9 commits into
apache:master
from
freeznet:freeznet/validate-sts-bytes
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
reviewed
Feb 26, 2024
...unctions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/ComponentImpl.java
Outdated
Show resolved
Hide resolved
...unctions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/ComponentImpl.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22127 +/- ##
=============================================
+ Coverage 34.05% 73.57% +39.51%
- Complexity 12150 32637 +20487
=============================================
Files 1659 1877 +218
Lines 129418 139528 +10110
Branches 14173 15307 +1134
=============================================
+ Hits 44079 102660 +58581
+ Misses 79497 28899 -50598
- Partials 5842 7969 +2127
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Feb 27, 2024
jiangpengcheng
approved these changes
Feb 27, 2024
Technoboy-
pushed a commit
that referenced
this pull request
Feb 27, 2024
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.2
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.2.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22126
Main Issue: #xyz
PIP: #xyz
Motivation
When submitting the
putstate
requests with other libs such as pulsar-admin-go, theFunctionState
JSON string may contain the default value of string or int, so the functions worker may use an incorrect value when the user submits withbytesString
. See apache/pulsar-client-go#1184 for more details.Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: freeznet#10