-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][admin] Expose the offload threshold in seconds to the admin #22101
[improve][admin] Expose the offload threshold in seconds to the admin #22101
Conversation
--- ### Motivation We have two configurations to trigger the offload automatically, time and bytes. We only expose the bytes in the admin but didn't expose the time in the admin. When we want to disable it, we need to set both of them to the -1. But we didn't expose the time settings, the offload will never be disabled.
@zymap Please add the following content to your PR description and select a checkbox:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22101 +/- ##
=============================================
+ Coverage 36.89% 73.58% +36.68%
- Complexity 12161 32592 +20431
=============================================
Files 1734 1874 +140
Lines 132201 139354 +7153
Branches 14466 15279 +813
=============================================
+ Hits 48770 102537 +53767
+ Misses 76937 28909 -48028
- Partials 6494 7908 +1414
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR depends on TimeUnitToSecondsConverter, which has not been cherry-picked to branch-3.0. |
We are reverting this commit from branch-3.0. |
@zymap Plz raise another PR to branch-3.0 without relying on TimeUnitToSecondsConverter(because TimeUnitToSecondsConverter is not available in branch-3.0), if possible. (targeting release 3.0.4) |
…apache#22101) (cherry picked from commit 48c7e32)
#22169 a new PR to branch-3.0 @heesung-sn |
…he amdin (apache#22101)" This reverts commit 1fe3853.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
We have two configurations to trigger the offload automatically, time and bytes. We only expose the bytes in the admin but didn't expose the time in the admin. When we want to disable it, we need to set both of them to the -1. But we didn't expose the time settings, the offload will never be disabled.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: