Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][build] Fix building java-test-image without setting IMAGE_JDK_MAJOR_VERSION #22095

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Feb 22, 2024

Motivation

In the current build, it is necessary to set IMAGE_JDK_MAJOR_VERSION environment variable. It's better to have the values set by default

Modifications

  • add a solution to properly set defaults for IMAGE_JDK_MAJOR_VERSION, UBUNTU_MIRROR and UBUNTU_SECURITY_MIRROR.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

…_MAJOR_VERSION env

In the current build, it is necessary to set IMAGE_JDK_MAJOR_VERSION environment variable.
It's better to have the values set by default
@lhotari lhotari added this to the 3.3.0 milestone Feb 22, 2024
@lhotari lhotari requested review from merlimat and tisonkun February 22, 2024 09:25
@lhotari lhotari self-assigned this Feb 22, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 22, 2024
@lhotari lhotari requested a review from asafm February 22, 2024 10:44
@lhotari lhotari merged commit 48c85ab into apache:master Feb 22, 2024
51 of 52 checks passed
lhotari added a commit that referenced this pull request Apr 5, 2024
lhotari added a commit that referenced this pull request Apr 5, 2024
lhotari added a commit that referenced this pull request Apr 5, 2024
@lhotari
Copy link
Member Author

lhotari commented Apr 5, 2024

I similar change has been made directly to branch-3.0 (32cd7f5) and branch-3.1 (c27bcf0) to support setting UBUNTU_MIRROR using an environment variable and changing the default to http://archive.ubuntu.com/ubuntu/

nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 5, 2024
- similar change was made in master as part of apache#22095

(cherry picked from commit c27bcf0)

 Conflicts:
	pom.xml
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 8, 2024
- similar change was made in master as part of apache#22095

(cherry picked from commit c27bcf0)

 Conflicts:
	pom.xml
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants