[fix] Fixed implicit conversions from long -> int #22055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heesung-sn
approved these changes
Feb 15, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarStats.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #22055 +/- ##
============================================
- Coverage 73.71% 73.59% -0.12%
+ Complexity 32116 32074 -42
============================================
Files 1874 1874
Lines 139220 139220
Branches 15260 15260
============================================
- Hits 102628 102465 -163
- Misses 28695 28836 +141
- Partials 7897 7919 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lhotari
approved these changes
Feb 15, 2024
4 tasks
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Demogorgon314
added a commit
that referenced
this pull request
Feb 19, 2025
#23286) ### Motivation When upgrading broker version from `3.0.x` to `3.3.x` with `ExtensibleLoadManagerImpl` enabled, it will have an `Unable to read schema` exception. And the broker will fail to start. This issue is caused by #22055 . ### Modifications Add a new class `NonPersistentSystemTopic`, and it will use for system non-persistent topic.
lhotari
pushed a commit
that referenced
this pull request
Feb 20, 2025
#23286) ### Motivation When upgrading broker version from `3.0.x` to `3.3.x` with `ExtensibleLoadManagerImpl` enabled, it will have an `Unable to read schema` exception. And the broker will fail to start. This issue is caused by #22055 . ### Modifications Add a new class `NonPersistentSystemTopic`, and it will use for system non-persistent topic. (cherry picked from commit 7dbd8a5)
lhotari
pushed a commit
that referenced
this pull request
Feb 20, 2025
#23286) When upgrading broker version from `3.0.x` to `3.3.x` with `ExtensibleLoadManagerImpl` enabled, it will have an `Unable to read schema` exception. And the broker will fail to start. This issue is caused by #22055 . Add a new class `NonPersistentSystemTopic`, and it will use for system non-persistent topic. (cherry picked from commit 7dbd8a5)
lhotari
pushed a commit
that referenced
this pull request
Feb 20, 2025
#23286) When upgrading broker version from `3.0.x` to `3.3.x` with `ExtensibleLoadManagerImpl` enabled, it will have an `Unable to read schema` exception. And the broker will fail to start. This issue is caused by #22055 . Add a new class `NonPersistentSystemTopic`, and it will use for system non-persistent topic. (cherry picked from commit 7dbd8a5)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 27, 2025
apache#23286) When upgrading broker version from `3.0.x` to `3.3.x` with `ExtensibleLoadManagerImpl` enabled, it will have an `Unable to read schema` exception. And the broker will fail to start. This issue is caused by apache#22055 . Add a new class `NonPersistentSystemTopic`, and it will use for system non-persistent topic. (cherry picked from commit 7dbd8a5) (cherry picked from commit 1c86d25)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 27, 2025
apache#23286) ### Motivation When upgrading broker version from `3.0.x` to `3.3.x` with `ExtensibleLoadManagerImpl` enabled, it will have an `Unable to read schema` exception. And the broker will fail to start. This issue is caused by apache#22055 . ### Modifications Add a new class `NonPersistentSystemTopic`, and it will use for system non-persistent topic. (cherry picked from commit 7dbd8a5) (cherry picked from commit 5daea49)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 28, 2025
apache#23286) When upgrading broker version from `3.0.x` to `3.3.x` with `ExtensibleLoadManagerImpl` enabled, it will have an `Unable to read schema` exception. And the broker will fail to start. This issue is caused by apache#22055 . Add a new class `NonPersistentSystemTopic`, and it will use for system non-persistent topic. (cherry picked from commit 7dbd8a5) (cherry picked from commit 1c86d25)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 28, 2025
apache#23286) ### Motivation When upgrading broker version from `3.0.x` to `3.3.x` with `ExtensibleLoadManagerImpl` enabled, it will have an `Unable to read schema` exception. And the broker will fail to start. This issue is caused by apache#22055 . ### Modifications Add a new class `NonPersistentSystemTopic`, and it will use for system non-persistent topic. (cherry picked from commit 7dbd8a5) (cherry picked from commit 5daea49)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 2, 2025
apache#23286) When upgrading broker version from `3.0.x` to `3.3.x` with `ExtensibleLoadManagerImpl` enabled, it will have an `Unable to read schema` exception. And the broker will fail to start. This issue is caused by apache#22055 . Add a new class `NonPersistentSystemTopic`, and it will use for system non-persistent topic. (cherry picked from commit 7dbd8a5) (cherry picked from commit 1c86d25)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 2, 2025
apache#23286) When upgrading broker version from `3.0.x` to `3.3.x` with `ExtensibleLoadManagerImpl` enabled, it will have an `Unable to read schema` exception. And the broker will fail to start. This issue is caused by apache#22055 . Add a new class `NonPersistentSystemTopic`, and it will use for system non-persistent topic. (cherry picked from commit 7dbd8a5) (cherry picked from commit 1c86d25)
shibd
pushed a commit
that referenced
this pull request
Mar 7, 2025
#23286) When upgrading broker version from `3.0.x` to `3.3.x` with `ExtensibleLoadManagerImpl` enabled, it will have an `Unable to read schema` exception. And the broker will fail to start. This issue is caused by #22055 . Add a new class `NonPersistentSystemTopic`, and it will use for system non-persistent topic. (cherry picked from commit 7dbd8a5) (cherry picked from commit 1c86d25)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix
Implicit narrowing conversion in compound assignmentissues reported by CodeQL scannerDoes this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: