Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] PIP-335: Pulsar with Oxia integration test #22045

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Feb 9, 2024

PIP: 335

Motivation

Added integration test for Pulsar & BookKeeper cluster with Oxia metadata store.

Modifications

  • Removed the init-cluster.sh script that was invoked in the ZK container. Instead use a separate container and call pulsar initialize-cluster-metadata from the Java code.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: merlimat#11

@merlimat merlimat added area/test type/feature The PR added a new feature or issue requested a new feature labels Feb 9, 2024
@merlimat merlimat added this to the 3.3.0 milestone Feb 9, 2024
@merlimat merlimat self-assigned this Feb 9, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 9, 2024
@merlimat merlimat requested a review from heesung-sn February 9, 2024 16:24
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a83e9ed) 36.63% compared to head (d59c952) 73.69%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #22045       +/-   ##
=============================================
+ Coverage     36.63%   73.69%   +37.06%     
- Complexity    12445    32442    +19997     
=============================================
  Files          1729     1865      +136     
  Lines        132076   138968     +6892     
  Branches      14452    15236      +784     
=============================================
+ Hits          48381   102415    +54034     
+ Misses        77296    28651    -48645     
- Partials       6399     7902     +1503     
Flag Coverage Δ
inttests 24.47% <ø> (+0.33%) ⬆️
systests 24.30% <ø> (+0.29%) ⬆️
unittests 72.96% <ø> (+40.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1442 files with indirect coverage changes

@merlimat merlimat merged commit 2b75ca0 into apache:master Feb 9, 2024
56 checks passed
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test doc-not-needed Your PR changes do not impact docs ready-to-test type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants