-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][io] AzureDataExplorer/Kusto Sink for Pulsar #22006
Conversation
…tps://learn.microsoft.com/en-us/azure/data-explorer/) (#2) * Added ADX Sink for Pulsar * Added test cases and E2E tests * Formatting and refactoring --------- Co-authored-by: Abhishek Saharn <[email protected]>
@asaharn Please add the following content to your PR description and select a checkbox:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @asaharn ! Looks really good in general. A few small details to revisit.
pulsar-io/azure-data-explorer/src/main/java/org/apache/pulsar/io/azuredataexplorer/ADXSink.java
Show resolved
Hide resolved
pom changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's one more change needed for handling secrets. I'm sorry I missed that in the initial review.
.../azure-data-explorer/src/main/java/org/apache/pulsar/io/azuredataexplorer/ADXSinkConfig.java
Outdated
Show resolved
Hide resolved
.../azure-data-explorer/src/main/java/org/apache/pulsar/io/azuredataexplorer/ADXSinkConfig.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @david-streamlio. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments about .gitignore
and the mockito-inline
dependency that is no longer needed in Mockito 5.x.x.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #22006 +/- ##
=============================================
+ Coverage 36.44% 73.58% +37.14%
- Complexity 12369 32572 +20203
=============================================
Files 1727 1874 +147
Lines 131879 139220 +7341
Branches 14419 15260 +841
=============================================
+ Hits 48057 102445 +54388
+ Misses 77404 28862 -48542
- Partials 6418 7913 +1495
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thanks for the great work @asaharn . Merging this. |
- https://learn.microsoft.com/en-us/azure/data-explorer/ Co-authored-by: Ramachandran A G <[email protected]>
Motivation
This PR introduces an Azure Data Explorer (ADX) sink connector for Apache Pulsar. Streamlining the ingestion process, it solves the challenge of seamlessly transferring data from Pulsar to ADX clusters.
Modifications
We have added a new Azure Data Explorer (ADX) sink connector tailored for Apache Pulsar, enabling smooth and optimized data transfer from Pulsar to ADX clusters. The modification includes the integration of key functionalities and configurations necessary for seamless data ingestion.
Verifying this change
(Please pick either of the following options)
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: asaharn#2