[improve] [test] Remove redudant test code

[thetumbled]

Motivation

The logic of these three methods testHealthCheckup, testHealthCheckupV1, testHealthCheckupV2 are same except the TopicVersion variable, we can introduce a @DataProvider to replace them.

Modifications

introduce

    @DataProvider(name = "topicVersion")
    public static Object[][] topicVersions() {
        return new Object[][] {
                { null },
                { TopicVersion.V1 },
                { TopicVersion.V2 },
        };
    }

Verifying this change

• Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: thetumbled#40

[thetumbled]

PTAL, thanks. @lhotari @poorbarcode @codelipenghui @mattisonchao

[thetumbled]

/pulsarbot rerun-failure-checks

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fce0717) 72.90% compared to head (6563b45) 73.61%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #21999      +/-   ##
============================================
+ Coverage     72.90%   73.61%   +0.71%     
- Complexity    32464    32479      +15     
============================================
  Files          1850     1863      +13     
  Lines        138611   138812     +201     
  Branches      15201    15215      +14     
============================================
+ Hits         101052   102191    +1139     
+ Misses        29711    28724     -987     
- Partials       7848     7897      +49     

Flag	Coverage Δ
inttests	24.05% <ø> (?)
systests	23.93% <ø> (?)
unittests	72.90% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 195 files with indirect coverage changes