[improve][client] Mention partitioning in failover priorityLevel javaDoc #21980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: apache#21922 ### Motivation Clarify when priorityLevel is active for failover subscriptions. ### Modifications Update javaDoc comment to specify paritioned topics and indicate insignificance for non-partitioned. ### Verifying this change - [X] Make sure that the change passes the CI checks. This change is a trivial rework / code cleanup without any test coverage. ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation - [X] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: N/A
github-actions
bot
added
the
doc
Technoboy-
approved these changes
Jan 31, 2024
|
This seems to be running up against #19307 Java 1.17.0.10 is now available and purportedly fixes the issue. |
merlimat
reviewed
Jan 31, 2024
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java
Outdated
Show resolved
Hide resolved
…onsumerBuilder.java Co-authored-by: Matteo Merli <[email protected]>
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…Doc (apache#21980) Co-authored-by: Matteo Merli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #21922
Motivation
Clarify when priorityLevel is active for failover subscriptions.
Modifications
Update javaDoc comment to specify paritioned topics and indicate insignificance for non-partitioned.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: N/A