Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][build] Remove duplicate mapping key in docker-compose yaml file #21979

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

Denovo1998
Copy link
Contributor

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

When I try to start the docker-compose after the error is as follows:
CleanShot 2024-01-27 at 15 48 13@2x

Modifications

Remove duplicate mapping key in docker-compose/kitchen-sink
CleanShot 2024-01-27 at 16 14 47@2x

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 27, 2024
@Denovo1998 Denovo1998 changed the title [fix][docker-compose] Remove duplicate mapping key in docker-compose yaml file [fix][build] Remove duplicate mapping key in docker-compose yaml file Jan 27, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d37d31f) 73.61% compared to head (0d72137) 73.67%.
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #21979      +/-   ##
============================================
+ Coverage     73.61%   73.67%   +0.06%     
- Complexity    32433    32463      +30     
============================================
  Files          1861     1861              
  Lines        138738   138738              
  Branches      15200    15200              
============================================
+ Hits         102130   102214      +84     
+ Misses        28704    28622      -82     
+ Partials       7904     7902       -2     
Flag Coverage Δ
inttests 24.08% <ø> (-0.04%) ⬇️
systests 23.86% <ø> (+0.22%) ⬆️
unittests 72.92% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 79 files with indirect coverage changes

@lhotari lhotari merged commit 8a18043 into apache:master Jan 28, 2024
50 of 51 checks passed
@Denovo1998 Denovo1998 deleted the remove_duplicate_mapping_key branch January 28, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants