Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][broker] Reduce ResourceGroup log #21957

Merged
merged 1 commit into from
Jan 24, 2024
Merged

[improve][broker] Reduce ResourceGroup log #21957

merged 1 commit into from
Jan 24, 2024

Conversation

nodece
Copy link
Member

@nodece nodece commented Jan 23, 2024

Motivation

When a ResourceGroup doesn't have any throughput, the resourceUsagePublishTask doesn't report the throughput data to the RESOURCE_USAGE_TOPIC topic, which causes the calculateQuotaPeriodicTask will print the following logs.

2024-01-23T09:19:10,164+0000 [pulsar-2-5] INFO  org.apache.pulsar.broker.resourcegroup.ResourceGroupService - getLocalUsageStatsFromBrokerReports: no usage report found for broker=pulsar://broker-a-2:6650 and monClass=Dispatch
2024-01-23T09:19:10,164+0000 [pulsar-2-5] INFO  org.apache.pulsar.broker.resourcegroup.ResourceGroupService - getLocalUsageStatsFromBrokerReports: no usage report found for broker=pulsar://broker-a-2:6650 and monClass=Publish
2024-01-23T09:19:10,164+0000 [pulsar-2-5] INFO  org.apache.pulsar.broker.resourcegroup.ResourceGroupService - getLocalUsageStatsFromBrokerReports: no usage report found for broker=pulsar://broker-a-2:6650 and monClass=Dispatch
2024-01-23T09:20:10,201+0000 [pulsar-2-7] INFO  org.apache.pulsar.broker.resourcegroup.ResourceGroupService - getLocalUsageStatsFromBrokerReports: no usage report found for broker=pulsar://broker-a-2:6650 and monClass=Publish
2024-01-23T09:20:10,201+0000 [pulsar-2-7] INFO  org.apache.pulsar.broker.resourcegroup.ResourceGroupService - getLocalUsageStatsFromBrokerReports: no usage report found for broker=pulsar://broker-a-2:6650 and monClass=Dispatch
2024-01-23T09:20:10,203+0000 [pulsar-2-7] INFO  org.apache.pulsar.broker.resourcegroup.ResourceGroupService - getLocalUsageStatsFromBrokerReports: no usage report found for broker=pulsar://broker-a-2:6650 and monClass=Publish
2024-01-23T09:20:10,203+0000 [pulsar-2-7] INFO  org.apache.pulsar.broker.resourcegroup.ResourceGroupService - getLocalUsageStatsFromBrokerReports: no usage report found for broker=pulsar://broker-a-2:6650 and monClass=Dispatch
2024-01-23T09:21:10,213+0000 [pulsar-2-9] INFO  org.apache.pulsar.broker.resourcegroup.ResourceGroupService - getLocalUsageStatsFromBrokerReports: no usage report found for broker=pulsar://broker-a-2:6650 and monClass=Publish
2024-01-23T09:21:10,213+0000 [pulsar-2-9] INFO  org.apache.pulsar.broker.resourcegroup.ResourceGroupService - getLocalUsageStatsFromBrokerReports: no usage report found for broker=pulsar://broker-a-2:6650 and monClass=Dispatch
2024-01-23T09:21:10,213+0000 [pulsar-2-9] INFO  org.apache.pulsar.broker.resourcegroup.ResourceGroupService - getLocalUsageStatsFromBrokerReports: no usage report found for broker=pulsar://broker-a-2:6650 and monClass=Publish
2024-01-23T09:21:10,213+0000 [pulsar-2-9] INFO  org.apache.pulsar.broker.resourcegroup.ResourceGroupService - getLocalUsageStatsFromBrokerReports: no usage report found for broker=pulsar://broker-a-2:6650 and monClass=Dispatch
2024-01-23T09:22:10,215+0000 [pulsar-2-5] INFO  org.apache.pulsar.broker.resourcegroup.ResourceGroupService - getLocalUsageStatsFromBrokerReports: no usage report found for broker=pulsar://broker-a-2:6650 and monClass=Publish
2024-01-23T09:22:10,219+0000 [pulsar-2-5] INFO  org.apache.pulsar.broker.resourcegroup.ResourceGroupService - getLocalUsageStatsFromBrokerReports: no usage report found for broker=pulsar://broker-a-2:6650 and monClass=Dispatch
2024-01-23T09:22:10,219+0000 [pulsar-2-5] INFO  org.apache.pulsar.broker.resourcegroup.ResourceGroupService - getLocalUsageStatsFromBrokerReports: no usage report found for broker=pulsar://broker-a-2:6650 and monClass=Publish
2024-01-23T09:22:10,219+0000 [pulsar-2-5] INFO  org.apache.pulsar.broker.resourcegroup.ResourceGroupService - getLocalUsageStatsFromBrokerReports: no usage report found for broker=pulsar://broker-a-2:6650 and monClass=Dispatch
2024-01-23T09:23:10,217+0000 [pulsar-2-12] INFO  org.apache.pulsar.broker.resourcegroup.ResourceGroupService - getLocalUsageStatsFromBrokerReports: no usage report found for broker=pulsar://broker-a-2:6650 and monClass=Publish
2024-01-23T09:23:10,224+0000 [pulsar-2-12] INFO  org.apache.pulsar.broker.resourcegroup.ResourceGroupService - getLocalUsageStatsFromBrokerReports: no usage report found for broker=pulsar://broker-a-2:6650 and monClass=Dispatch
2024-01-23T09:23:10,225+0000 [pulsar-2-12] INFO  org.apache.pulsar.broker.resourcegroup.ResourceGroupService - getLocalUsageStatsFromBrokerReports: no usage report found for broker=pulsar://broker-a-2:6650 and monClass=Publish
2024-01-23T09:23:10,225+0000 [pulsar-2-12] INFO  org.apache.pulsar.broker.resourcegroup.ResourceGroupService - getLocalUsageStatsFromBrokerReports: no usage report found for broker=pulsar://broker-a-2:6650 and monClass=Dispatch

Modifications

  • Improve the following method log level from info to debug
    • getLocalUsageStatsFromBrokerReports
    • computeLocalQuota

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@nodece nodece self-assigned this Jan 23, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 23, 2024
@nodece nodece closed this Jan 23, 2024
@nodece nodece reopened this Jan 23, 2024
@nodece nodece added this to the 3.3.0 milestone Jan 23, 2024
@Technoboy- Technoboy- merged commit 1b5550d into apache:master Jan 24, 2024
65 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@liudezhi2098 liudezhi2098 liudezhi2098 approved these changes

Assignees

@nodece nodece

Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nodece @Technoboy- @liudezhi2098