-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][fn] Throw 404 RestException when state key not found #21921
Merged
Technoboy-
merged 2 commits into
apache:master
from
jiangpengcheng:fix_incorrect_exception
Jan 19, 2024
Merged
[fix][fn] Throw 404 RestException when state key not found #21921
Technoboy-
merged 2 commits into
apache:master
from
jiangpengcheng:fix_incorrect_exception
Jan 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
approved these changes
Jan 18, 2024
freeznet
approved these changes
Jan 18, 2024
Oh, can we add a test for this? We find this in the release stage. |
Sure, i will add a test tomorrow |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21921 +/- ##
=============================================
+ Coverage 36.46% 73.57% +37.11%
- Complexity 12390 32390 +20000
=============================================
Files 1725 1861 +136
Lines 131701 138595 +6894
Branches 14401 15185 +784
=============================================
+ Hits 48027 101978 +53951
+ Misses 77254 28724 -48530
- Partials 6420 7893 +1473
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
pushed a commit
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/blocker
Indicate the PR or issue that should block the release until it gets resolved
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
500 error is returned for
querystate
when the key doesn't exist.it's related to #21597
Modifications
return 404 error when key doesn't exist
Verifying this change
Make sure that the change passes the CI checks.
Add tests to query non-exist state key in:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: jiangpengcheng#22