Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][cli] error out when --destinationBroker is set when --bundle is empty #21879

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

heesung-sn
Copy link
Contributor

@heesung-sn heesung-sn commented Jan 10, 2024

Motivation

The 'pulsar-admin namespaces unload' cli silently ignores --destinationBroker when --bundle is empty. I think we can error out in this case and clarify the usage of destinationBroker.

Modifications

  • error out when --destinationBroker is set when --bundle is empty
  • updated the --destinationBroker option description.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 10, 2024
Copy link
Contributor

@dragosvictor dragosvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@merlimat merlimat added this to the 3.3.0 milestone Jan 10, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46ec730) 73.54% compared to head (2b7ead2) 73.60%.
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #21879      +/-   ##
============================================
+ Coverage     73.54%   73.60%   +0.06%     
- Complexity    32311    32338      +27     
============================================
  Files          1859     1859              
  Lines        138281   138283       +2     
  Branches      15156    15157       +1     
============================================
+ Hits         101693   101783      +90     
+ Misses        28689    28625      -64     
+ Partials       7899     7875      -24     
Flag Coverage Δ
inttests 24.13% <0.00%> (-0.03%) ⬇️
systests 23.73% <0.00%> (-0.01%) ⬇️
unittests 72.87% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ava/org/apache/pulsar/admin/cli/CmdNamespaces.java 78.23% <100.00%> (+0.04%) ⬆️

... and 70 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants