-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Fix compaction/replication data loss when expire messages #21865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
changed the title
[fix][broker] Fix compaction data loss when expire messages
[fix][broker] Fix compaction/replication data loss when expire messages
Jan 9, 2024
coderzc
force-pushed
the
fix_ttl_compaction
branch
3 times, most recently
from
January 9, 2024 03:13
af3ffcd
to
9b9fbd7
Compare
coderzc
force-pushed
the
fix_ttl_compaction
branch
from
January 9, 2024 03:14
9b9fbd7
to
42790cb
Compare
coderzc
added
type/bug
The PR fixed a bug or issue reported a bug
area/broker
ready-to-test
labels
Jan 9, 2024
merlimat
approved these changes
Jan 10, 2024
poorbarcode
approved these changes
Jan 10, 2024
merlimat
pushed a commit
that referenced
this pull request
Jan 11, 2024
merlimat
pushed a commit
that referenced
this pull request
Jan 11, 2024
Technoboy-
pushed a commit
that referenced
this pull request
Jan 16, 2024
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 1, 2024
…es (apache#21865) (cherry picked from commit d9029c6)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
…es (apache#21865) (cherry picked from commit d9029c6)
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
area/compaction
cherry-picked/branch-3.0
cherry-picked/branch-3.1
cherry-picked/branch-3.2
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.3
release/3.1.3
release/3.2.1
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When expiring messages during compaction, we may lose the middle message due to
__compaction
cursor mark-delete position being advanced. So I think we should skip TTL check for__compaction
.replicators also have a similar problem, so also skip the expiration check of replicator
Modifications
__compaction
and skip expire__compaction
subscriptions.cursor.properties
when the mark deletes for the cursor.replicator
, and remove the expired message replicator.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: