Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] [broker] PIP-299-part-3: Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled #21837

Merged
merged 7 commits into from
Jan 5, 2024
Merged

[improve] [broker] PIP-299-part-3: Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled #21837

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dfd1ed5
[improve] [broker] PIP-299-part-1: Add dynamic config support: dispat…
poorbarcode Jan 2, 2024
a9c1cfb
-
poorbarcode Jan 2, 2024
a775a20
address comment
poorbarcode Jan 2, 2024
0dcb79b
address comment
poorbarcode Jan 3, 2024
e8003fe
address comment
poorbarcode Jan 3, 2024
b48a6b7
address comment
poorbarcode Jan 3, 2024
87dcc97
address comments
poorbarcode Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2754,16 +2754,6 @@ private void updateDispatchPauseOnAckStatePersistentEnabled() {
// Update policies.
PersistentTopic persistentTopic = (PersistentTopic) topic;
persistentTopic.updateDispatchPauseOnAckStatePersistentEnabled();
// Trigger new read if subscriptions has been paused before.
if (!pulsar().getConfiguration().isDispatcherPauseOnAckStatePersistentEnabled()) {
persistentTopic.updateDispatchPauseOnAckStatePersistentEnabled();
persistentTopic.getSubscriptions().forEach((sName, subscription) -> {
if (subscription.getDispatcher() == null) {
return;
}
subscription.getDispatcher().afterAckMessages(null, 0);
});
}
}
});
});
Expand Down
15 changes: 15 additions & 0 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3770,6 +3770,21 @@ public boolean isDispatcherPauseOnAckStatePersistentEnabled() {
return b == null ? false : b.booleanValue();
}

@Override
public void updateDispatchPauseOnAckStatePersistentEnabled() {
super.updateDispatchPauseOnAckStatePersistentEnabled();
// Trigger new read if subscriptions has been paused before.
if (!brokerService.getPulsar().getConfiguration().isDispatcherPauseOnAckStatePersistentEnabled()) {
updateDispatchPauseOnAckStatePersistentEnabled();
getSubscriptions().forEach((sName, subscription) -> {
if (subscription.getDispatcher() == null) {
return;
}
subscription.getDispatcher().afterAckMessages(null, 0);
});
}
}

@Override
public void onUpdate(TopicPolicies policies) {
if (log.isDebugEnabled()) {
Expand Down