Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][sec] Align some namespace level policy authorisation check #21640

Merged
merged 1 commit into from
Dec 4, 2023
Merged

[improve][sec] Align some namespace level policy authorisation check #21640

merged 1 commit into from
Dec 4, 2023

Conversation

mattisonchao
Copy link
Member

Motivation

Some of our namespace level policy already has namespace operation, and the read method has a corresponding authorisation check, but write does not have it.

Modifications

  • Align missing authorisation check.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Some of our namespace level policy already has namespace operation,
and the read method has a corresponding authorisation check, but write does not have it.
@mattisonchao mattisonchao self-assigned this Nov 29, 2023
@mattisonchao mattisonchao added this to the 3.2.0 milestone Nov 29, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 29, 2023
Copy link

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Technoboy-
Copy link
Contributor

Cherry-pick to branch-2.11 by #22248

@lhotari
Copy link
Member

lhotari commented Mar 12, 2024

@Technoboy- please tag the release in this PR to track the cherry-picking. Just wondering if this should go to 3.1.x and 3.0.x too if it's going to 2.11.x .

@Technoboy-
Copy link
Contributor

@Technoboy- please tag the release in this PR to track the cherry-picking. Just wondering if this should go to 3.1.x and 3.0.x too if it's going to 2.11.x .

Oh, sorry, miss this comment.
I have cherry-picked to branch-3.2 and branch-3.0.

nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request May 13, 2024
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants