[fix][test] Fix resource leak in TransactionCoordinatorClientTest #21380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
approved these changes
Oct 17, 2023
Codecov Report
@@ Coverage Diff @@
## master #21380 +/- ##
=============================================
+ Coverage 34.55% 73.25% +38.70%
- Complexity 12096 32558 +20462
=============================================
Files 1711 1888 +177
Lines 130647 140246 +9599
Branches 14236 15411 +1175
=============================================
+ Hits 45142 102742 +57600
+ Misses 79490 29426 -50064
- Partials 6015 8078 +2063
Flags with carried forward coverage won't be shown. Click here to find out more. |
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 13, 2024
…ache#21380) (cherry picked from commit cb7c98a) (cherry picked from commit 8ecfd64)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2024
…ache#21380) (cherry picked from commit cb7c98a) (cherry picked from commit 8ecfd64)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
TransactionCoordinatorClientTest doesn't properly close all resources.
Modifications
Close transactionCoordinatorClient and stop bkEnsemble
Documentation
docdoc-requireddoc-not-neededdoc-complete