-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] PIP-299-part-2: add config dispatcherPauseOnAckStatePersistentEnabled #21370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should merge this PR after all the implementation is done to avoid a release that only released the configuration but without the implementation.
Sure. It is #21423, please help review it. Thanks |
a837e5a
to
dfff62e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21370 +/- ##
=============================================
+ Coverage 36.38% 73.56% +37.18%
- Complexity 12299 32289 +19990
=============================================
Files 1722 1858 +136
Lines 131206 138146 +6940
Branches 14351 15141 +790
=============================================
+ Hits 47739 101633 +53894
+ Misses 77092 28653 -48439
- Partials 6375 7860 +1485
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Motivation & Modifications
The part 2 of PIP-299: add config dispatcherPauseOnAckStatePersistentEnabled
Subsequent PRs:
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x