Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] PIP-299-part-2: add config dispatcherPauseOnAckStatePersistentEnabled #21370

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

poorbarcode
Copy link
Contributor

@poorbarcode poorbarcode commented Oct 16, 2023

Motivation & Modifications

The part 2 of PIP-299: add config dispatcherPauseOnAckStatePersistentEnabled

Subsequent PRs:

  • part-1: Implementation
  • part-3: Dynamic config
  • part-4: Topic policies support.
  • part-5: Doc

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 16, 2023
Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge this PR after all the implementation is done to avoid a release that only released the configuration but without the implementation.

@poorbarcode
Copy link
Contributor Author

@codelipenghui

I think we should merge this PR after all the implementation is done to avoid a release that only released the configuration but without the implementation.

Sure. It is #21423, please help review it. Thanks

@poorbarcode poorbarcode changed the title [improve][broker] PIP-299 add config dispatcherPauseOnAckStatePersistentEnabled [improve][broker] PIP-299-part-2 add config dispatcherPauseOnAckStatePersistentEnabled Oct 23, 2023
@poorbarcode poorbarcode changed the title [improve][broker] PIP-299-part-2 add config dispatcherPauseOnAckStatePersistentEnabled [improve][broker] PIP-299-part-2: add config dispatcherPauseOnAckStatePersistentEnabled Oct 23, 2023
@Technoboy- Technoboy- added this to the 3.3.0 milestone Dec 22, 2023
@codelipenghui codelipenghui added ready-to-test type/feature The PR added a new feature or issue requested a new feature area/broker labels Jan 2, 2024
@codelipenghui codelipenghui reopened this Jan 2, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6da1f5) 36.38% compared to head (dfff62e) 73.56%.
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #21370       +/-   ##
=============================================
+ Coverage     36.38%   73.56%   +37.18%     
- Complexity    12299    32289    +19990     
=============================================
  Files          1722     1858      +136     
  Lines        131206   138146     +6940     
  Branches      14351    15141      +790     
=============================================
+ Hits          47739   101633    +53894     
+ Misses        77092    28653    -48439     
- Partials       6375     7860     +1485     
Flag Coverage Δ
inttests 24.22% <100.00%> (+0.02%) ⬆️
systests 23.71% <100.00%> (+0.09%) ⬆️
unittests 72.86% <100.00%> (+40.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...org/apache/pulsar/broker/ServiceConfiguration.java 99.39% <100.00%> (+1.42%) ⬆️

... and 1436 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker doc-not-needed Your PR changes do not impact docs ready-to-test type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants