Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Fix compaction subscription delete by inactive subscription check. #20983

Conversation

lifepuzzlefun
Copy link
Contributor

@lifepuzzlefun lifepuzzlefun commented Aug 12, 2023

Fixes #20982

Motivation

do not delete compaction cursor when enable subscription inactive check.

Modifications

if subscription is compaction subscription skip check inactive check.

Verifying this change

add unit test to check this. see testCheckInactiveSubscriptionsShouldNotDeleteCompactionCursor

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Aug 12, 2023
@lifepuzzlefun
Copy link
Contributor Author

@coderzc @gaoran10 please take a look : -)

@coderzc coderzc added type/bug The PR fixed a bug or issue reported a bug area/broker labels Aug 12, 2023
@lifepuzzlefun
Copy link
Contributor Author

sorry for the late reply. the comments has been applied. please take a look again : -) @mattisonchao @Technoboy-

@Technoboy- Technoboy- closed this Aug 21, 2023
@Technoboy- Technoboy- reopened this Aug 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Merging #20983 (128ff3f) into master (9862884) will increase coverage by 39.24%.
Report is 25 commits behind head on master.
The diff coverage is 83.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #20983       +/-   ##
=============================================
+ Coverage     33.53%   72.78%   +39.24%     
- Complexity    12174    32211    +20037     
=============================================
  Files          1621     1875      +254     
  Lines        126919   140824    +13905     
  Branches      13851    15738     +1887     
=============================================
+ Hits          42561   102497    +59936     
+ Misses        78745    30193    -48552     
- Partials       5613     8134     +2521     
Flag Coverage Δ
inttests 24.19% <66.66%> (-0.09%) ⬇️
systests 25.16% <66.66%> (?)
unittests 72.09% <83.33%> (+40.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rization/MultiRolesTokenAuthorizationProvider.java 60.43% <40.00%> (+60.43%) ⬆️
...sar/broker/service/persistent/PersistentTopic.java 79.92% <100.00%> (+26.56%) ⬆️
...ava/org/apache/pulsar/utils/StatsOutputStream.java 100.00% <100.00%> (+29.09%) ⬆️

... and 1520 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Compaction cursor deleted by inactive subscription check
9 participants