-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Fix compaction subscription delete by inactive subscription check. #20983
Merged
Technoboy-
merged 5 commits into
apache:master
from
lifepuzzlefun:fix_inactive_subscription_delete_compaction_cursor
Aug 21, 2023
Merged
[fix][broker] Fix compaction subscription delete by inactive subscription check. #20983
Technoboy-
merged 5 commits into
apache:master
from
lifepuzzlefun:fix_inactive_subscription_delete_compaction_cursor
Aug 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
approved these changes
Aug 12, 2023
gaoran10
approved these changes
Aug 13, 2023
Technoboy-
reviewed
Aug 13, 2023
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
sorry for the late reply. the comments has been applied. please take a look again : -) @mattisonchao @Technoboy- |
Technoboy-
reviewed
Aug 19, 2023
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
Technoboy-
approved these changes
Aug 21, 2023
Codecov Report
@@ Coverage Diff @@
## master #20983 +/- ##
=============================================
+ Coverage 33.53% 72.78% +39.24%
- Complexity 12174 32211 +20037
=============================================
Files 1621 1875 +254
Lines 126919 140824 +13905
Branches 13851 15738 +1887
=============================================
+ Hits 42561 102497 +59936
+ Misses 78745 30193 -48552
- Partials 5613 8134 +2521
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
pushed a commit
that referenced
this pull request
Aug 21, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Aug 21, 2023
2 tasks
shibd
pushed a commit
to shibd/pulsar
that referenced
this pull request
Oct 22, 2023
…tion check. (apache#20983) (cherry picked from commit 43cd86d)
shibd
pushed a commit
to shibd/pulsar
that referenced
this pull request
Oct 24, 2023
…tion check. (apache#20983) (cherry picked from commit 43cd86d)
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
cherry-picked/branch-2.11
cherry-picked/branch-3.0
cherry-picked/branch-3.1
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/2.9.5
release/2.10.7
release/2.11.3
release/3.0.2
release/3.1.1
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20982
Motivation
do not delete compaction cursor when enable subscription inactive check.
Modifications
if subscription is compaction subscription skip check inactive check.
Verifying this change
add unit test to check this. see
testCheckInactiveSubscriptionsShouldNotDeleteCompactionCursor
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: