[fix][broker] Pass bytesToRead when reading compacted entries
#20850
+16
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
changed the title
bytesToRead when reading compacted entries.bytesToRead when reading compacted entries
coderzc
force-pushed
the
fix_readcompacted_entry
branch
2 times, most recently
from
886aad2 to
66c0563
Compare
coderzc
force-pushed
the
fix_readcompacted_entry
branch
from
66c0563 to
e150b91
Compare
BewareMyPower
approved these changes
Jul 21, 2023
mattisonchao
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When we read compacted entries, we miss
bytesToRead, we should pass it.Modifications
Pass
bytesToReadwhen reading compacted entries.Add wait parameter to make the method support non-wait mode.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: