[fix] [cli] the variable producerName of BatchMsgContainer is null #20819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
added
type/bug
|
/pulsarbot rerun-failure-checks |
| @@ -304,6 +304,13 @@ public OpSendMsg createOpSendMsg() throws IOException { | |||
| ByteBufPair cmd = producer.sendMessage(producer.producerId, messageMetadata.getSequenceId(), | |||
| messageMetadata.getHighestSequenceId(), numMessagesInBatch, messageMetadata, encryptedPayload); | |||
|
|
|||
| if (log.isInfoEnabled()) { | |||
There was a problem hiding this comment.
Maybe using the debug level is much better.
coderzc
approved these changes
Jul 17, 2023
Codecov Report
@@ Coverage Diff @@
## master #20819 +/- ##
============================================
- Coverage 73.19% 73.12% -0.08%
+ Complexity 32185 32175 -10
============================================
Files 1867 1868 +1
Lines 139071 139159 +88
Branches 15305 15314 +9
============================================
- Hits 101795 101762 -33
- Misses 29234 29336 +102
- Partials 8042 8061 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
liangyepianzhou
approved these changes
Jul 17, 2023
RobertIndie
approved these changes
Jul 17, 2023
liangyepianzhou
added a commit
that referenced
this pull request
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If the producer name is generated by the Broker, the producer will update the variable
producerNameafter connecting, but not update the same variable of the batch message container.Modifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x