[improve][broker] Improve CompactedTopicImpl lock #20697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
changed the title
mattisonchao
approved these changes
Jun 30, 2023
| callback.readEntriesComplete(Collections.emptyList(), readEntriesCtx); | ||
| return CompletableFuture.completedFuture(null); | ||
| } | ||
| if (startPoint == NEWER_THAN_COMPACTED && compactionHorizon.compareTo(cursorPosition) < 0) { | ||
| cursor.asyncReadEntriesOrWait(numberOfEntriesToRead, callback, readEntriesCtx, |
There was a problem hiding this comment.
do we need keep this logic ?
There was a problem hiding this comment.
Condition is always false because it has been judged line-107.
codelipenghui
added
type/enhancement
codelipenghui
approved these changes
Jul 3, 2023
|
/pulsarbot run-failure-checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, some
synchronizedis used in CompactedTopicImpl to avoid data contention, but it does not completely avoid data contention due to asynchronous operations and may lead to cursor skipping some data.The cursor may skip some data due to
compactionHorizonbe updated:pulsar/pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactedTopicImpl.java
Line 114 in e360379
Modifications
synchronized.compactionHorizonunchanged when reading compacted data.volatileforcompactedTopicContext.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: