Skip to content

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Jun 28, 2023

Fixes #20661

Motivation

master branch is blocked by PulsarSinksTest.testElasticSearch8Sink failing, see #20661

Modifications

  • disable downloading of geoip database when Elastic container starts
  • enable logging of Elastic container output
  • upgrade Elastic 8 container version from 8.5.1 to 8.5.3
  • allow disk usage to go beyond 90% when running Elastic in integration tests

Matching PR in forked repository

PR in forked repository: lhotari#151

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari self-assigned this Jun 28, 2023
@lhotari lhotari requested a review from tisonkun June 28, 2023 12:52
@apache apache deleted a comment from github-actions bot Jun 28, 2023
@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jun 28, 2023
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great
Thank you very much

Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Technoboy- Technoboy- added this to the 3.1.0 milestone Jun 28, 2023
@lhotari
Copy link
Member Author

lhotari commented Jun 28, 2023

I finally found the root cause. It's not the geoip download, but it's the default Elastic configuration that it stops writes when the disk usage goes over 90%. I've now added a setting to disable the disk usage threshold.
commit is d959eb4 . Similar setting is applied in https://github.com/elastic/elastic-github-actions/blob/562b8b6ae4677da97273ff6bc4d630ce96ecbaa5/elasticsearch/run-elasticsearch.sh#L41

@lhotari
Copy link
Member Author

lhotari commented Jun 28, 2023

The logging helped find the issue. However, it's only a warning that gets printed:

2023-06-28T15:14:43,179 - INFO - [docker-java-stream--1170024553:ElasticSearchSinkTester@113] - elastic> {"@timestamp":"2023-06-28T15:14:43.176Z", "log.level": "WARN", "message":"high disk watermark [90%] exceeded on [WSN4y7xITamrUzTvic-eEg][94f6a74e1f83][/usr/share/elasticsearch/data] free: 8.1gb[9.7%], shards will be relocated away from this node; currently relocating away shards totalling [0] bytes; the node is expected to continue to exceed the high disk watermark when these relocations are complete", "ecs.version": "1.2.0","service.name":"ES_ECS","event.dataset":"elasticsearch.server","process.thread.name":"elasticsearch[94f6a74e1f83][masterService#updateTask][T#1]","log.logger":"org.elasticsearch.cluster.routing.allocation.DiskThresholdMonitor","elasticsearch.cluster.uuid":"_NqZoH7vRxqPTe21y53uhQ","elasticsearch.node.id":"WSN4y7xITamrUzTvic-eEg","elasticsearch.node.name":"94f6a74e1f83","elasticsearch.cluster.name":"docker-cluster"}

@lhotari lhotari changed the title [improve][test] Disable geoip download and enable logging for Elastic Testcontainers [improve][test] Disable disk usage threshold & geoip download and enable logging for Elastic Testcontainers Jun 28, 2023
@lhotari lhotari merged commit e97fe5b into apache:master Jun 28, 2023
lhotari added a commit that referenced this pull request Jun 28, 2023
…ble logging for Elastic Testcontainers (#20671)

(cherry picked from commit e97fe5b)
lhotari added a commit that referenced this pull request Jun 28, 2023
…ble logging for Elastic Testcontainers (#20671)

(cherry picked from commit e97fe5b)

# Conflicts:
#	tests/integration/src/test/java/org/apache/pulsar/tests/integration/topologies/PulsarCluster.java
lhotari added a commit to lhotari/pulsar that referenced this pull request Jun 28, 2023
…for Elastic Testcontainers

- backports apache#20671 to branch-2.10
lhotari added a commit to datastax/pulsar that referenced this pull request Jun 28, 2023
…ble logging for Elastic Testcontainers (apache#20671)

(cherry picked from commit e97fe5b)

# Conflicts:
#	tests/integration/src/test/java/org/apache/pulsar/tests/integration/topologies/PulsarCluster.java
lhotari added a commit to datastax/pulsar that referenced this pull request Jun 28, 2023
…ble logging for Elastic Testcontainers (apache#20671) (#193)

Cherry-picks upstream apache#20671

(cherry picked from commit e97fe5b)

# Conflicts:
#	tests/integration/src/test/java/org/apache/pulsar/tests/integration/topologies/PulsarCluster.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Master branch is broken due to failing test testElasticSearch8Sink

8 participants