[fix][broker] Should not throw NotFoundException when metadata already exists. #20539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y exists. ## Motivation Make the Exception more clear. ## Modification Return the `404 NoFound` to `409 Conflict` when metadata already exists.
freeznet
approved these changes
Jun 8, 2023
Codecov Report
@@ Coverage Diff @@
## master #20539 +/- ##
============================================
+ Coverage 72.93% 72.96% +0.02%
- Complexity 31930 31952 +22
============================================
Files 1867 1867
Lines 138555 138562 +7
Branches 15218 15220 +2
============================================
+ Hits 101059 101100 +41
+ Misses 29466 29447 -19
+ Partials 8030 8015 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make the Exception more clear.
Modification
Return the
409 Conflictinstead of404 NoFoundwhen metadata already exists.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: