[improve][broker] Remove uneffective solution for reducing GC pressure #20428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
added
the
type/cleanup
lhotari
requested review from
merlimat,
rdhabalia,
eolivelli,
codelipenghui,
BewareMyPower,
tisonkun,
michaeljmarshall and
mattisonchao
1 task
|
/pulsarbot rerun-failure-checks |
tisonkun
reviewed
May 31, 2023
| @JsonIgnore | ||
| private int producerNameLength; | ||
|
|
||
| private String producerName; |
There was a problem hiding this comment.
How can these changes affect JSON serde code path? I don't know if we pass or persist these classes via JSON somewhere.
If no, @JsonIgnore can be redundant. If so, adding new serialize field may affect especially this is a class under pulsar-common.
There was a problem hiding this comment.
The former @JsonIgnore annotations were needed because of the extra ordinary solution to store String values. They aren't needed anymore.
There was a problem hiding this comment.
There is no change in JSON serialization and deserialization from an external viewpoint.
tisonkun
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The PublisherStatsImpl and ConsumerStatsImpl classes contain an uneffective solution for reducing GC pressure.
This code is confusing and doesn't help. Instead, ordinary fields are used.
The solution was originally introduced by #1480.
Modifications
Additional Context
The Guava Interner based solution in #20432 could be a way to reduce GC pressure in a more effective way if there is a need for that.
Documentation
docdoc-requireddoc-not-neededdoc-complete