-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][fn] Go functions need to use static grpcPort in k8s runtime #20404
[fix][fn] Go functions need to use static grpcPort in k8s runtime #20404
Conversation
@flowchartsman Please add the following content to your PR description and select a checkbox:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this @flowchartsman, thanks for your PR! I agree with the direction, but I have just one detail to discuss before we move forward.
...e/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeFactory.java
Outdated
Show resolved
Hide resolved
Looks like two test failures are flaky and one is potentially legitimate:
|
It looks like the only failures I have now are related to Codecov 👍 |
Codecov Report
@@ Coverage Diff @@
## master #20404 +/- ##
============================================
+ Coverage 72.59% 72.90% +0.31%
- Complexity 31719 31900 +181
============================================
Files 1867 1867
Lines 138523 138548 +25
Branches 15204 15210 +6
============================================
+ Hits 100555 101009 +454
+ Misses 29955 29515 -440
- Partials 8013 8024 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ache#20404) (cherry picked from commit 7e6ca31)
Fixes #20403
Motivation
Allow Go pulsar functions to respond to the function worker for status requests.
Modifications
Make KubernetesRuntimeFactory assign static grpcPort instead of a random available port, so that the pod will respond correctly to status requests.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage. I didn't see any tests for this, but if needed I can add them.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: flowchartsman#2