[fix][broker] Fix skip message API when hole messages exists

[crossoverJie]

Fixes #20262

Motivation

When there are hole messages, there is a bug in the API of skipping the message, please refer to the issue for the specific reason

Modifications

Remove recyclePositionRangeConverter, revert to normal loop.

Verifying this change

• Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: (crossoverJie#8)

[liangyepianzhou]

LGTM

[liangyepianzhou]

@poorbarcode @Technoboy- Please help take a look, thanks. 😸

[codecov-commenter]

Codecov Report

Merging #20326 (2004bf8) into master (5d5ec94) will increase coverage by 34.45%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #20326       +/-   ##
=============================================
+ Coverage     37.92%   72.38%   +34.45%     
- Complexity    12694    32022    +19328     
=============================================
  Files          1691     1867      +176     
  Lines        129047   143534    +14487     
  Branches      14070    16439     +2369     
=============================================
+ Hits          48942   103897    +54955     
+ Misses        73777    31250    -42527     
- Partials       6328     8387     +2059     

Flag	Coverage Δ
inttests	25.08% <ø> (+0.90%)	⬆️
systests	26.17% <ø> (+0.98%)	⬆️
unittests	71.36% <ø> (+37.90%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...che/bookkeeper/mledger/impl/ManagedCursorImpl.java	77.60% <ø> (+28.44%)	⬆️

... and 1440 files with indirect coverage changes

[lhotari]

@crossoverJie @liangyepianzhou I have a question about this change.

issue #20262 description contains "The reason for this issue is that the recycle() function reuses objects, causing the object referenced by r to change during runtime."

What is the reason that the lowerEndpoint is recycled and the upperEndpoint isn't?
why not just skip recycling completely? Omitting recycling completely would be fine if recycling is problematic.

[liangyepianzhou]

We recycle an object after it is no longer used to save GC pause.
But the upperEndpoint is still used after being recycled, which makes this issue.
The lowerEndpoint is no longer used after being recycled, so we can recycle it.

state.startPosition = r.upperEndpoint();

[michaeljmarshall]

As discussed on the mailing list https://lists.apache.org/thread/w4jzk27qhtosgsz7l9bmhf1t7o9mxjhp, there is no plan to release 2.9.6, so I am going to remove the release/2.9.6 label