[fix] [broker] Producer created by replicator is not displayed in topic stats #20229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
reviewed
May 5, 2023
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Show resolved
Hide resolved
gaoran10
approved these changes
May 5, 2023
|
/pulsarbot rerun-failure-checks |
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Show resolved
Hide resolved
liangyepianzhou
approved these changes
May 5, 2023
poorbarcode
added
type/bug
|
/pulsarbot rerun-failure-checks |
1 similar comment
|
/pulsarbot rerun-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #20229 +/- ##
=============================================
+ Coverage 34.48% 72.93% +38.45%
+ Complexity 12537 3696 -8841
=============================================
Files 1614 1868 +254
Lines 126170 138592 +12422
Branches 13771 15246 +1475
=============================================
+ Hits 43509 101082 +57573
+ Misses 77053 29459 -47594
- Partials 5608 8051 +2443
Flags with carried forward coverage won't be shown. Click here to find out more.
|
congbobo184
approved these changes
May 6, 2023
poorbarcode
added a commit
that referenced
this pull request
May 6, 2023
…ic stats (#20229) ### Motivation A producer of the remote cluster is automatically created when replication is turned on. But we can't see anything about it from the response of `(remote cluster) pulsar-admin topic stats` ### Modifications Make this producer displayed in the topic stats (cherry picked from commit 9f7a539)
poorbarcode
added a commit
that referenced
this pull request
May 6, 2023
…ic stats (#20229) ### Motivation A producer of the remote cluster is automatically created when replication is turned on. But we can't see anything about it from the response of `(remote cluster) pulsar-admin topic stats` ### Modifications Make this producer displayed in the topic stats (cherry picked from commit 9f7a539)
poorbarcode
added a commit
that referenced
this pull request
May 7, 2023
…ic stats (#20229) ### Motivation A producer of the remote cluster is automatically created when replication is turned on. But we can't see anything about it from the response of `(remote cluster) pulsar-admin topic stats` ### Modifications Make this producer displayed in the topic stats (cherry picked from commit 9f7a539)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 11, 2023
…ic stats (apache#20229) ### Motivation A producer of the remote cluster is automatically created when replication is turned on. But we can't see anything about it from the response of `(remote cluster) pulsar-admin topic stats` ### Modifications Make this producer displayed in the topic stats (cherry picked from commit 9f7a539) (cherry picked from commit bf117bb)
Closed
2 tasks
|
This PR introduced something that could be considered a regression. The issue is #22442 . @poorbarcode Please check that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is an error
Producer with name xxx already exists, but there is no producer in the response oftopic stats.A producer of the remote cluster is automatically created when replication is turned on. But we can't see anything about it from the response of
(remote cluster) pulsar-admin topic statsModifications
Make this producer displayed in the topic stats
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in the forked repository
PR in forked repository: