[fix][broker] Release EntryBuffer after parse proto object #20170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -127,7 +127,9 @@ private CompletableFuture<Void> addSnapshotSegments(LedgerHandle ledgerHandle, | |||
| private SnapshotMetadata parseSnapshotMetadataEntry(LedgerEntry ledgerEntry) { | |||
| try { | |||
| ByteBuf entryBuffer = ledgerEntry.getEntryBuffer(); | |||
| return SnapshotMetadata.parseFrom(entryBuffer.nioBuffer()); | |||
| SnapshotMetadata snapshotMetadata = SnapshotMetadata.parseFrom(entryBuffer.nioBuffer()); | |||
There was a problem hiding this comment.
You should add try-finally here to aovid any exception.
| @@ -140,6 +142,7 @@ private List<SnapshotSegment> parseSnapshotSegmentEntries(Enumeration<LedgerEntr | |||
| SnapshotSegment snapshotSegment = new SnapshotSegment(); | |||
| ByteBuf entryBuffer = ledgerEntry.getEntryBuffer(); | |||
| snapshotSegment.parseFrom(entryBuffer, entryBuffer.readableBytes()); | |||
| entryBuffer.release(); | |||
mattisonchao
approved these changes
Apr 23, 2023
coderzc
force-pushed
the
fix_release_entry_buffer
branch
6 times, most recently
from
de36c72 to
03f6154
Compare
coderzc
force-pushed
the
fix_release_entry_buffer
branch
from
03f6154 to
950f73b
Compare
Codecov Report
@@ Coverage Diff @@
## master #20170 +/- ##
============================================
+ Coverage 72.55% 72.95% +0.39%
- Complexity 3661 31960 +28299
============================================
Files 1868 1868
Lines 138457 138468 +11
Branches 15235 15236 +1
============================================
+ Hits 100458 101017 +559
+ Misses 29953 29415 -538
+ Partials 8046 8036 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
poorbarcode
pushed a commit
that referenced
this pull request
May 7, 2023
(cherry picked from commit 35e9897)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation & Modifications
Release EntryBuffer after parsing the proto object, It was introduced by PR #20158
Reduce data copy on the addEntry
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: