[improve][broker] Cache LedgerHandle in BookkeeperBucketSnapshotStorage #20117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
added
type/enhancement
coderzc
changed the title
This reverts commit 4e54007.
coderzc
force-pushed
the
improve_bucket_storage_cache
branch
from
db05856 to
f7c23e6
Compare
coderzc
force-pushed
the
improve_bucket_storage_cache
branch
from
f7c23e6 to
00f09a9
Compare
| } | ||
|
|
||
| @Override | ||
| public CompletableFuture<Void> deleteBucketSnapshot(long bucketId) { | ||
| ledgerHandleCache.remove(bucketId); |
There was a problem hiding this comment.
We should close this handle here.
...r/src/main/java/org/apache/pulsar/broker/delayed/bucket/BookkeeperBucketSnapshotStorage.java
Outdated
Show resolved
Hide resolved
| future.complete(handle); | ||
| } | ||
| }, null, metadata); | ||
| return future; | ||
| } | ||
|
|
||
| private CompletableFuture<LedgerHandle> getLedgerHandle(Long ledgerId) { | ||
| LedgerHandle ledgerHandle = ledgerHandleCache.get(ledgerId); |
There was a problem hiding this comment.
There is a race condition, you should consider use compute here.
case: read - if -modify
mattisonchao
requested changes
Apr 18, 2023
| @@ -186,6 +178,10 @@ private CompletableFuture<LedgerHandle> openLedger(Long ledgerId) { | |||
| LedgerPassword, | |||
| (rc, handle, ctx) -> { | |||
| if (rc != BKException.Code.OK) { | |||
| ledgerHandleFutureCache.remove(ledgerId, future); | |||
There was a problem hiding this comment.
If the future is complete like sync, may it cause a deadlock?
coderzc
force-pushed
the
improve_bucket_storage_cache
branch
from
a90c93c to
4d0b405
Compare
coderzc
force-pushed
the
improve_bucket_storage_cache
branch
from
4d0b405 to
2a65382
Compare
|
@coderzc we're in code freeze for 3.0. Is this a blocker or fixing a regression from 2.11 ? Otherwise I suggest to move this to 3.1 milestone. |
OK, it can be moved to 3.1 |
mattisonchao
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP: #16763
Motivation
#20111 (review)
Modifications
Cache this ledger in BookkeeperBucketSnapshotStorage
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: