Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] [broker] fix use error TimeUnit to record publish latency #20074

Merged
merged 2 commits into from
Apr 12, 2023
Merged

[fix] [broker] fix use error TimeUnit to record publish latency #20074

merged 2 commits into from
Apr 12, 2023

Conversation

TakaHiR07
Copy link
Contributor

@TakaHiR07 TakaHiR07 commented Apr 12, 2023 •
edited
Loading

Motivation

recordAddLatency use nanoTime and TimeUnit.MICROSECONDS by mistake

Modifications

change to TimeUnit.NANOSECONDS

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: TakaHiR07#7

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 12, 2023
tisonkun
tisonkun approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

nodece
nodece approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@tisonkun
Copy link
Member

Merging...

Thanks for your contribution @TakaHiR07!

@tisonkun tisonkun merged commit 547d792 into apache:master Apr 12, 2023
@poorbarcode poorbarcode added this to the 3.1.0 milestone May 7, 2023
poorbarcode pushed a commit that referenced this pull request May 7, 2023
@TakaHiR07 @poorbarcode
[fix] [broker] error TimeUnit to record publish latency (#20074)
c7cffba 
Co-authored-by: fanjianye <[email protected]>
Co-authored-by: tison <[email protected]>
(cherry picked from commit 547d792)
Technoboy- pushed a commit that referenced this pull request May 9, 2023
@TakaHiR07 @tisonkun @Technoboy-
[fix] [broker] error TimeUnit to record publish latency (#20074)
f0b4a71 
Co-authored-by: fanjianye <[email protected]>
Co-authored-by: tison <[email protected]>
Technoboy- pushed a commit that referenced this pull request May 23, 2023
@TakaHiR07 @tisonkun @Technoboy-
[fix] [broker] error TimeUnit to record publish latency (#20074)
8be5279 
Co-authored-by: fanjianye <[email protected]>
Co-authored-by: tison <[email protected]>
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jun 6, 2023
@TakaHiR07 @nicoloboschi
[fix] [broker] error TimeUnit to record publish latency (apache#20074)
a00e8af 
Co-authored-by: fanjianye <[email protected]>
Co-authored-by: tison <[email protected]>
(cherry picked from commit 8be5279)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnonHxy AnonHxy AnonHxy approved these changes

@nodece nodece nodece approved these changes

@tisonkun tisonkun tisonkun approved these changes

Assignees

@TakaHiR07 TakaHiR07

Labels
area/broker cherry-picked/branch-2.10 cherry-picked/branch-2.11 cherry-picked/branch-3.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/2.10.5 release/2.11.2 release/3.0.1
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@TakaHiR07 @tisonkun @AnonHxy @nodece @Technoboy- @poorbarcode