-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Fix getPartitionedStats miss subscription's messageAckRate #19870
Merged
Technoboy-
merged 1 commit into
apache:master
from
wangjialing218:branch-partition-stats
Apr 23, 2023
Merged
[fix][broker] Fix getPartitionedStats miss subscription's messageAckRate #19870
Technoboy-
merged 1 commit into
apache:master
from
wangjialing218:branch-partition-stats
Apr 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@wangjialing218 Please add the following content to your PR description and select a checkbox:
|
Technoboy-
approved these changes
Mar 23, 2023
poorbarcode
reviewed
Mar 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you write a test?
Since we will start the RC version of
So drag this PR to |
1ea2398
to
77ba342
Compare
Technoboy-
pushed a commit
that referenced
this pull request
Apr 23, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Apr 23, 2023
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 11, 2023
…ate (apache#19870) (cherry picked from commit f8dc8c1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
cherry-picked/branch-2.10
cherry-picked/branch-2.11
cherry-picked/branch-3.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/2.10.5
release/2.11.2
release/3.0.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Use

bin/pulsar-admin topics partitioned-stats
get partitioned topic stats, subscription'smessageAckRate
always be 0.Modifications
Fix the aggregation logic of subscription stats.
According to the code,
chunkedMessageRate
has same issue.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete