Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Fix getPartitionedStats miss subscription's messageAckRate #19870

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

wangjialing218
Copy link
Contributor

@wangjialing218 wangjialing218 commented Mar 21, 2023

Motivation

Use bin/pulsar-admin topics partitioned-stats get partitioned topic stats, subscription's messageAckRate always be 0.
stats

Modifications

Fix the aggregation logic of subscription stats.
According to the code, chunkedMessageRate has same issue.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions
Copy link

@wangjialing218 Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@wangjialing218 wangjialing218 changed the title fix getPartitionedStats miss subscription's messageAckRate [fix][broker] fix getPartitionedStats miss subscription's messageAckRate Mar 21, 2023
@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Mar 21, 2023
@Technoboy- Technoboy- added this to the 3.0.0 milestone Mar 23, 2023
Copy link
Contributor

@poorbarcode poorbarcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you write a test?

@poorbarcode
Copy link
Contributor

Since we will start the RC version of 3.0.0 on 2023-04-11, I will change the label/milestone of PR who have not been merged.

  • The PR of type feature is deferred to 3.1.0
  • The PR of type fix is deferred to 3.0.1

So drag this PR to 3.0.1

@poorbarcode poorbarcode modified the milestones: 3.0.0, 3.1.0 Apr 10, 2023
@Technoboy- Technoboy- closed this Apr 12, 2023
@Technoboy- Technoboy- reopened this Apr 12, 2023
@Technoboy- Technoboy- force-pushed the branch-partition-stats branch from 1ea2398 to 77ba342 Compare April 12, 2023 14:37
@Technoboy- Technoboy- changed the title [fix][broker] fix getPartitionedStats miss subscription's messageAckRate [fix][broker] Fix getPartitionedStats miss subscription's messageAckRate Apr 23, 2023
@Technoboy- Technoboy- merged commit d3158bf into apache:master Apr 23, 2023
poorbarcode pushed a commit that referenced this pull request May 7, 2023
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants