[fix][client] Release the orphan producers after the primary consumer is closed #19858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
changed the title
poorbarcode
changed the title
poorbarcode
changed the title
| return closeFuture; | ||
| return closeFuture.thenCompose(ignore -> { | ||
| if (retryLetterProducer != null){ | ||
| return retryLetterProducer.closeAsync(); |
There was a problem hiding this comment.
Should we close them parallelly? Do you think we should make some special exception handling here?
There was a problem hiding this comment.
Should we close them parallelly?
Fixed.
Do you think we should make some special exception handling here?
Yes, if closing these producers fail, users can not retry to close them again, so just print a warning log. Or two other implementations:
- Make this method retryable.
- Do retry these producers' close silently
Since there are few scenarios where failure occurs, such as when the connection has been broken (no longer necessary to retry the close), just print a warning log.
Technoboy-
approved these changes
Mar 23, 2023
lhotari
added
type/bug
lhotari
changed the title
Codecov Report
@@ Coverage Diff @@
## master #19858 +/- ##
=============================================
+ Coverage 25.11% 38.16% +13.05%
- Complexity 205 1364 +1159
=============================================
Files 1680 1686 +6
Lines 127176 133729 +6553
Branches 13863 15400 +1537
=============================================
+ Hits 31942 51040 +19098
+ Misses 90242 75961 -14281
- Partials 4992 6728 +1736
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/pulsarbot rerun-failure-checks |
michaeljmarshall
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Great work! I had tried to fix this a long time ago with #10159 but it was never completed.
This was referenced Apr 6, 2023
poorbarcode
added a commit
that referenced
this pull request
May 6, 2023
… is closed (#19858) Motivation: The producers ["retryLetterProducer", "deadLetterProducer"] will be auto-created by consumers if enabled `DLQ`, but these producers will not close after consumers are closed. Modifications: Auto close "retryLetterProducer" and "deadLetterProducer" after the primary consumer is closed (cherry picked from commit 94ae340)
poorbarcode
added a commit
that referenced
this pull request
May 6, 2023
… is closed (#19858) Motivation: The producers ["retryLetterProducer", "deadLetterProducer"] will be auto-created by consumers if enabled `DLQ`, but these producers will not close after consumers are closed. Modifications: Auto close "retryLetterProducer" and "deadLetterProducer" after the primary consumer is closed (cherry picked from commit 94ae340)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 11, 2023
… is closed (apache#19858) Motivation: The producers ["retryLetterProducer", "deadLetterProducer"] will be auto-created by consumers if enabled `DLQ`, but these producers will not close after consumers are closed. Modifications: Auto close "retryLetterProducer" and "deadLetterProducer" after the primary consumer is closed (cherry picked from commit 94ae340) (cherry picked from commit a0ff522)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The producers ["retryLetterProducer", "deadLetterProducer"] will be auto-created by consumers if enabled
DLQ, but these producers will not close after consumers are closed.Modifications
Auto close "retryLetterProducer" and "deadLetterProducer" after the primary consumer is closed
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: