-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] [Perf] PerformanceProducer do not produce expected number of messages. #19775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnonHxy
reviewed
Mar 14, 2023
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceProducer.java
Show resolved
Hide resolved
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceProducer.java
Outdated
Show resolved
Hide resolved
AnonHxy
approved these changes
Mar 14, 2023
codelipenghui
approved these changes
Mar 14, 2023
The pr had no activity for 30 days, mark with Stale label. |
tisonkun
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Merging...
Technoboy-
pushed a commit
that referenced
this pull request
Jun 26, 2023
…ssages. (#19775) Co-authored-by: tison <[email protected]>
As discussed on the mailing list https://lists.apache.org/thread/w4jzk27qhtosgsz7l9bmhf1t7o9mxjhp, there is no plan to release 2.9.6, so I am going to remove the release/2.9.6 label |
Technoboy-
pushed a commit
that referenced
this pull request
Jul 3, 2023
…ssages. (#19775) Co-authored-by: tison <[email protected]>
Technoboy-
pushed a commit
that referenced
this pull request
Jul 4, 2023
…ssages. (#19775) Co-authored-by: tison <[email protected]>
tisonkun
pushed a commit
to tisonkun/pulsar
that referenced
this pull request
Jul 12, 2023
…documentation This closes apache#19775.
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 17, 2023
…ssages. (apache#19775) Co-authored-by: tison <[email protected]> (cherry picked from commit 25bfc46)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/tool
cherry-picked/branch-2.10
cherry-picked/branch-2.11
cherry-picked/branch-3.0
doc-not-needed
Your PR changes do not impact docs
release/2.10.5
release/2.11.2
release/3.0.1
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19774
Motivation
when one of threads produce enough messages, it will shutdown all threads, which may do not produce enough messages yet.
Modifications
remove
system.exit()
.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: thetumbled#19