Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [Perf] PerformanceProducer do not produce expected number of messages. #19775

Merged
merged 9 commits into from
Jun 13, 2023

Conversation

thetumbled
Copy link
Member

@thetumbled thetumbled commented Mar 10, 2023

Fixes #19774

Motivation

when one of threads produce enough messages, it will shutdown all threads, which may do not produce enough messages yet.

Modifications

remove system.exit().

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: thetumbled#19

@AnonHxy AnonHxy changed the title [Bug] [Perf] PerformanceProducer do not produce expected number of messages. [fix] [Perf] PerformanceProducer do not produce expected number of messages. Mar 14, 2023
@codelipenghui codelipenghui added this to the 3.0.0 milestone Mar 14, 2023
@codelipenghui codelipenghui added type/bug The PR fixed a bug or issue reported a bug area/tool labels Mar 14, 2023
@cbornet cbornet modified the milestones: 3.0.0, 3.1.0 Apr 11, 2023
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label May 12, 2023
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Merging...

@michaeljmarshall
Copy link
Member

As discussed on the mailing list https://lists.apache.org/thread/w4jzk27qhtosgsz7l9bmhf1t7o9mxjhp, there is no plan to release 2.9.6, so I am going to remove the release/2.9.6 label

Technoboy- pushed a commit that referenced this pull request Jul 3, 2023
Technoboy- pushed a commit that referenced this pull request Jul 4, 2023
tisonkun pushed a commit to tisonkun/pulsar that referenced this pull request Jul 12, 2023
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Perf] PerformanceProducer do not produce expected number of messages.
8 participants