[fix][broker] AbstractBatchedMetadataStore - use AlreadyClosedException instead of IllegalStateException #19284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of IllegalStateException
codelipenghui
approved these changes
Jan 19, 2023
mattisonchao
approved these changes
Jan 19, 2023
|
@codelipenghui I am not sure that it is worth to cover this change with a test case. |
eolivelli
changed the title
eolivelli
added a commit
to datastax/pulsar
that referenced
this pull request
Jan 19, 2023
…on instead of IllegalStateException (apache#19284) (cherry picked from commit d3e112e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the broker is shutting down AbstractBatchedMetadataStore completes exceptionally the pending operations with a generic IllegalStateException. All the code that is depending on the MetadataStore usually expects instances of MetadataStoreException and they may not properly react to this error.
This is generally not a big deal because the broker is shutting down, but we should improve it
Modifications
Complete the pending operations with AlreadyClosedException instead of IllegalStateException
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-complete