-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Add topic_load_failed
metric
#19236
Conversation
Tests to be completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a test for it
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarStats.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a test for it
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarStats.java
Outdated
Show resolved
Hide resolved
topic_load_failed
metrictopic_load_failed
metric
GitHub provides this function. After you associate the issue with pr, closing the pr will automatically close the issue. |
The pr had no activity for 30 days, mark with Stale label. |
topic_load_failed
metrictopic_load_failed
metric
topic_load_failed
metrictopic_load_failed
metric
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/BrokerOperabilityMetrics.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #19236 +/- ##
============================================
- Coverage 72.95% 72.92% -0.04%
+ Complexity 31914 31900 -14
============================================
Files 1867 1867
Lines 138485 138498 +13
Branches 15202 15202
============================================
- Hits 101037 101003 -34
- Misses 29438 29469 +31
- Partials 8010 8026 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/pulsarbot run-failure-checks |
I wonder if this caused #20492 ? |
@tjiuming this PR is labeled with |
Co-authored-by: daojun <[email protected]> (cherry picked from commit 43b3622)
Co-authored-by: daojun <[email protected]> (cherry picked from commit 43b3622)
Co-authored-by: daojun <[email protected]> (cherry picked from commit 43b3622)
Co-authored-by: daojun <[email protected]> (cherry picked from commit 43b3622)
Co-authored-by: daojun <[email protected]> (cherry picked from commit 43b3622)
PIP: #18979
Motivation
Add
topic_load_failed
metricDoes this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: tjiuming#20