Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][build] Remove versions that are handled by netty-bom #18629

Merged
merged 1 commit into from
Nov 25, 2022
Merged

[improve][build] Remove versions that are handled by netty-bom #18629

merged 1 commit into from
Nov 25, 2022

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Nov 25, 2022 •
edited
Loading

Motivation

netty-bom includes the correct Netty tcnative version which is compatible with a particular Netty version. Because of this reason, it's an unnecessary overhead to duplicate the information in Pulsar pom.xml .

Modifications

  • remove netty-tc-native.version from Pulsar's pom.xml
  • remove unnecessary dependency management dependencies that are included in netty-bom
  • remove unnecessary definition of version for a netty dependency

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: lhotari#107

@lhotari lhotari requested a review from nicoloboschi November 25, 2022 09:45
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 25, 2022
@lhotari lhotari requested a review from tisonkun November 25, 2022 10:00
tisonkun
tisonkun approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@tisonkun
Copy link
Member

/pulsarbot run-failure-checks

tisonkun
tisonkun approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2022 •
edited
Loading

Codecov Report

Merging #18629 (49292b4) into master (cd85a67) will decrease coverage by 0.06%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18629      +/-   ##
============================================
- Coverage     47.39%   47.33%   -0.07%     
+ Complexity    10479    10473       -6     
============================================
  Files           698      698              
  Lines         68070    68079       +9     
  Branches       7279     7280       +1     
============================================
- Hits          32264    32223      -41     
- Misses        32228    32262      +34     
- Partials       3578     3594      +16
Flag Coverage Δ
unittests 47.33% <16.66%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pache/pulsar/broker/admin/v2/PersistentTopics.java 74.25% <ø> (+0.14%) ⬆️
...apache/pulsar/broker/service/TopicListService.java 40.80% <0.00%> (-14.12%) ⬇️
...pache/pulsar/client/impl/TableViewBuilderImpl.java 0.00% <0.00%> (ø)
...a/org/apache/pulsar/client/impl/TableViewImpl.java 0.00% <0.00%> (ø)
...pulsar/client/impl/TableViewConfigurationData.java 33.33% <50.00%> (+33.33%) ⬆️
...pache/pulsar/proxy/server/ProxyServiceStarter.java 60.66% <100.00%> (ø)
.../transaction/buffer/metadata/AbortTxnMetadata.java 28.57% <0.00%> (-57.15%) ⬇️
...ker/service/schema/exceptions/SchemaException.java 60.00% <0.00%> (-40.00%) ⬇️
.../pulsar/broker/service/SharedConsumerAssignor.java 51.85% <0.00%> (-25.93%) ⬇️
...tent/NonPersistentDispatcherMultipleConsumers.java 40.74% <0.00%> (-12.35%) ⬇️
... and 39 more

@nicoloboschi nicoloboschi merged commit b1a2036 into apache:master Nov 25, 2022
@nicoloboschi nicoloboschi added this to the 2.12.0 milestone Nov 25, 2022
labuladong pushed a commit to labuladong/pulsar that referenced this pull request Nov 28, 2022
@lhotari @labuladong
[improve][build] Remove versions that are handled by netty-bom (apach…
f42631e 
…e#18629)
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Dec 9, 2022
@lhotari @lifepuzzlefun
[improve][build] Remove versions that are handled by netty-bom (apach…
0cf233d 
…e#18629)
lhotari added a commit that referenced this pull request Dec 13, 2022
@lhotari
[improve][build] Remove versions that are handled by netty-bom (#18629)
0c9e8ea 
(cherry picked from commit b1a2036)
lhotari added a commit that referenced this pull request Dec 13, 2022
@lhotari
[improve][build] Remove versions that are handled by netty-bom (#18629)
1037468 
(cherry picked from commit b1a2036)
lhotari added a commit to datastax/pulsar that referenced this pull request Dec 13, 2022
@lhotari
[improve][build] Remove versions that are handled by netty-bom (apach…
f4bec73 
…e#18629)

(cherry picked from commit b1a2036)
(cherry picked from commit 0c9e8ea)
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Jan 10, 2023
@lhotari @lifepuzzlefun
[improve][build] Remove versions that are handled by netty-bom (apach…
c514278 
…e#18629)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@nicoloboschi nicoloboschi nicoloboschi approved these changes

@hezhangjian hezhangjian Awaiting requested review from hezhangjian

Assignees

@lhotari lhotari

Labels
cherry-picked/branch-2.10 cherry-picked/branch-2.11 doc-not-needed Your PR changes do not impact docs release/2.10.4 release/2.11.0
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lhotari @tisonkun @codecov-commenter @nicoloboschi @Technoboy- @liangyepianzhou