Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][broker] System topic writer/reader connection not counted #18603

Merged
merged 1 commit into from
Nov 28, 2022
Merged

[improve][broker] System topic writer/reader connection not counted #18603

merged 1 commit into from
Nov 28, 2022

Conversation

yuruguo
Copy link
Contributor

@yuruguo yuruguo commented Nov 24, 2022 •
edited
Loading

Motivation

This PR is a supplement to #18369.

  • AbstractTopic.isSameAddressProducersExceeded()
  • AbstractBaseDispatcher.isConsumersExceededOnSubscription()

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 24, 2022
@yuruguo yuruguo mentioned this pull request Nov 24, 2022
Open
@yuruguo yuruguo force-pushed the producer-consumer-exceed branch from 3d67d89 to 85bbaf1 Compare November 24, 2022 11:04
@yuruguo yuruguo self-assigned this Nov 24, 2022
@yuruguo yuruguo added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/broker release/2.11.1 release/2.10.3 release/2.9.5 labels Nov 24, 2022
@yuruguo yuruguo added this to the 2.12.0 milestone Nov 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2022 •
edited
Loading

Codecov Report

Merging #18603 (5239522) into master (cd85a67) will decrease coverage by 1.88%.
The diff coverage is 23.07%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18603      +/-   ##
============================================
- Coverage     47.39%   45.51%   -1.89%     
- Complexity    10479    10743     +264     
============================================
  Files           698      758      +60     
  Lines         68070    72839    +4769     
  Branches       7279     7813     +534     
============================================
+ Hits          32264    33152     +888     
- Misses        32228    35991    +3763     
- Partials       3578     3696     +118
Flag Coverage Δ
unittests 45.51% <23.07%> (-1.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pache/pulsar/broker/admin/v2/PersistentTopics.java 74.25% <ø> (+0.14%) ⬆️
...pache/pulsar/client/impl/TableViewBuilderImpl.java 0.00% <0.00%> (ø)
...a/org/apache/pulsar/client/impl/TableViewImpl.java 0.00% <0.00%> (ø)
.../pulsar/broker/service/AbstractBaseDispatcher.java 58.62% <25.00%> (-2.20%) ⬇️
...rg/apache/pulsar/broker/service/AbstractTopic.java 65.22% <50.00%> (+4.14%) ⬆️
...pulsar/client/impl/TableViewConfigurationData.java 33.33% <50.00%> (+33.33%) ⬆️
.../transaction/buffer/metadata/AbortTxnMetadata.java 28.57% <0.00%> (-57.15%) ⬇️
...rvice/schema/KeyValueSchemaCompatibilityCheck.java 21.62% <0.00%> (-45.95%) ⬇️
...e/pulsar/broker/service/EntryBatchIndexesAcks.java 82.14% <0.00%> (-10.72%) ⬇️
...ce/schema/validator/StructSchemaDataValidator.java 52.38% <0.00%> (-9.53%) ⬇️
... and 99 more

@yuruguo yuruguo force-pushed the producer-consumer-exceed branch from 85bbaf1 to ebaeb86 Compare November 25, 2022 01:39
@yuruguo yuruguo force-pushed the producer-consumer-exceed branch from ebaeb86 to 5239522 Compare November 25, 2022 03:18
@grssam grssam mentioned this pull request Nov 25, 2022
Merged
4 tasks
@codelipenghui codelipenghui merged commit a2fb562 into apache:master Nov 28, 2022
labuladong pushed a commit to labuladong/pulsar that referenced this pull request Nov 28, 2022
@yuruguo @labuladong
[improve][broker] System topic writer/reader connection not counted (a…
b933518 
…pache#18603)

This PR is a supplement to apache#18369.
- `AbstractTopic.isSameAddressProducersExceeded()`
- `AbstractBaseDispatcher.isConsumersExceededOnSubscription()`
congbobo184 pushed a commit that referenced this pull request Dec 6, 2022
@yuruguo
[improve][broker] System topic writer/reader connection not counted (#…
9ca74fc 
…18603)

This PR is a supplement to #18369.
- `AbstractTopic.isSameAddressProducersExceeded()`
- `AbstractBaseDispatcher.isConsumersExceededOnSubscription()`

(cherry picked from commit a2fb562)
@congbobo184 congbobo184 added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Dec 7, 2022
@Technoboy- Technoboy- mentioned this pull request Dec 8, 2022
Closed
2 tasks
Technoboy- pushed a commit that referenced this pull request Dec 8, 2022
@yuruguo @Technoboy-
[improve][broker] System topic writer/reader connection not counted (#…
cfd0479 
…18603)

This PR is a supplement to #18369.
- `AbstractTopic.isSameAddressProducersExceeded()`
- `AbstractBaseDispatcher.isConsumersExceededOnSubscription()`
Technoboy- pushed a commit that referenced this pull request Dec 8, 2022
@yuruguo @Technoboy-
[improve][broker] System topic writer/reader connection not counted (#…
b33bff9 
…18603)

This PR is a supplement to #18369.
- `AbstractTopic.isSameAddressProducersExceeded()`
- `AbstractBaseDispatcher.isConsumersExceededOnSubscription()`
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Dec 9, 2022
@yuruguo @lifepuzzlefun
[improve][broker] System topic writer/reader connection not counted (a…
67b9dd1 
…pache#18603)

This PR is a supplement to apache#18369.
- `AbstractTopic.isSameAddressProducersExceeded()`
- `AbstractBaseDispatcher.isConsumersExceededOnSubscription()`
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jan 10, 2023
@yuruguo @nicoloboschi
[improve][broker] System topic writer/reader connection not counted (a…
fd5d1a3 
…pache#18603)

This PR is a supplement to apache#18369.
- `AbstractTopic.isSameAddressProducersExceeded()`
- `AbstractBaseDispatcher.isConsumersExceededOnSubscription()`

(cherry picked from commit b33bff9)
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Jan 10, 2023
@yuruguo @lifepuzzlefun
[improve][broker] System topic writer/reader connection not counted (a…
97fb381 
…pache#18603)

This PR is a supplement to apache#18369.
- `AbstractTopic.isSameAddressProducersExceeded()`
- `AbstractBaseDispatcher.isConsumersExceededOnSubscription()`
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jan 11, 2023
@yuruguo @nicoloboschi
[improve][broker] System topic writer/reader connection not counted (a…
b7a3e7b 
…pache#18603)

This PR is a supplement to apache#18369.
- `AbstractTopic.isSameAddressProducersExceeded()`
- `AbstractBaseDispatcher.isConsumersExceededOnSubscription()`

(cherry picked from commit b33bff9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@mattisonchao mattisonchao Awaiting requested review from mattisonchao

Assignees

@yuruguo yuruguo

Labels
area/broker cherry-picked/branch-2.9 Archived: 2.9 is end of life cherry-picked/branch-2.10 cherry-picked/branch-2.11 doc-not-needed Your PR changes do not impact docs ready-to-test release/2.9.4 release/2.10.3 release/2.11.0 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@yuruguo @codecov-commenter @Technoboy- @codelipenghui @congbobo184