Add client-side lookup throttling #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
added
the
type/enhancement
merlimat
reviewed
Jan 31, 2017
| } | ||
|
|
||
| /** | ||
| * Configure total allowed concurrent lookup-request to prevent overload on broker. |
There was a problem hiding this comment.
We should note here in the javadoc that the default is 5000 and that one should not worry to change this unless you plan to produce/subscribe on 1000s of topics from the same client instance.
| } | ||
| }); | ||
| } else { | ||
| log.warn("{} Failed to add lookup-request into pending queue", requestId); |
There was a problem hiding this comment.
I'd rather keep this at debug level, since it is part of the normal operations flow
rdhabalia
force-pushed
the
client_throttling
branch
from
31602c3 to
3e40832
Compare
merlimat
approved these changes
Jan 31, 2017
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
Signed-off-by: xiaolong.ran <[email protected]> Fix nil pointer dereference of PartitionMetadataResponse
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
fix apache#181 This pull request fix the deadlock in kop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes, It is useful to throttle at client in order to avoid large number of concurrent lookup-requests going to broker while creating producers/consumers.
Modifications
Add client side lookup throttling while creating producer and consumer.
Result
Client can have capability to restrict number of concurrent lookup request to broker in order to throttle while creating producer/consumer.