[fix][fn] Do not delete managed packages when deleting functions #18030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
added
type/enhancement
codelipenghui
added
release/2.11.0
release/blocker
|
The issue is introduced by #14450, it's better to have this fix in 2.11.0 @Technoboy- |
jiangpengcheng
changed the title
jiangpengcheng
force-pushed
the
dont_delete_package_auto
branch
2 times, most recently
from
c430fa4 to
eca91cd
Compare
jiangpengcheng
force-pushed
the
dont_delete_package_auto
branch
from
eca91cd to
c0295c8
Compare
Codecov Report
@@ Coverage Diff @@
## master #18030 +/- ##
=============================================
+ Coverage 34.91% 50.71% +15.80%
- Complexity 5707 8698 +2991
=============================================
Files 607 607
Lines 53396 53511 +115
Branches 5712 5739 +27
=============================================
+ Hits 18644 27139 +8495
+ Misses 32119 23372 -8747
- Partials 2633 3000 +367
Flags with carried forward coverage won't be shown. Click here to find out more.
|
freeznet
approved these changes
Oct 21, 2022
|
/pulsarbot rerun-failure-checks |
nodece
approved these changes
Oct 24, 2022
nodece
requested review from
codelipenghui,
mattisonchao,
merlimat and
Technoboy-
|
/pulsarbot rerun-failure-checks |
Technoboy-
pushed a commit
that referenced
this pull request
Nov 15, 2022
Technoboy-
added
cherry-picked/branch-2.11
and removed
release/2.11.0
release/blocker
momo-jun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17982
Motivation
managed packages should not be deleted automatically when deleting function
Modifications
remove auto deletion logic for managed package
Verifying this change
Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository:
pr in my forked repo: jiangpengcheng#1