-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve] [broker] make consumer and producer can work even if schema ledger lost #18010
Open
poorbarcode
wants to merge
1
commit into
apache:master
Choose a base branch
from
poorbarcode:broken_ledger/schema
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@poorbarcode Please add the following content to your PR description and select a checkbox:
|
24e91c9
to
fd4d3fc
Compare
The pr had no activity for 30 days, mark with Stale label. |
Denovo1998
reviewed
Mar 11, 2023
pulsar-broker/src/test/java/org/apache/pulsar/broker/LedgerBrokenTest.java
Outdated
Show resolved
Hide resolved
Denovo1998
reviewed
Mar 17, 2023
...ar-broker/src/main/java/org/apache/pulsar/broker/service/schema/BookkeeperSchemaStorage.java
Show resolved
Hide resolved
5f71523
to
44f9bc6
Compare
44f9bc6
to
45b787e
Compare
15 tasks
2 tasks
This was referenced Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17221
Master Issue: #17221
Motivation
In the current implementation, if the
schema ledger
is lost, thepulsar client create consumer
andpulsar client create producer
will fail case by could not read the origin schema.Modifications
If enabled
autoSkipNonRecoverableData
, when theschema ledger
is lost, theconsumer
andproducer
can add new schemas without compatibility check(because the original schema definition cannot be found).Verifying this change
When the
schema ledger
is lost, if the newly added schema is not compatible with the schema in the historical message, consumers will still fail (because the compatibility check has been skipped).Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: