[fix][flaky-test]NamespaceServiceTest.flaky/testModularLoadManagerRemoveBundleAndLoad

[poorbarcode]

Fixes #17386

Motivation

In this test, we expect it works like this:

1. persistent broker data to ZK
2. receive notice: broker data changes, and refresh bundle data in memory
3. persistent bundle data which already updated in memory to ZK
4. verify bundle data persist correctly
5. delete namespace
6. verify bundle data deleted

But the flow works like this:

1. persistent broker data to ZK
2. (High light) race condition
   2-x. receive notice: broker data changes, and refresh bundle data in memory
   2-x. persistent bundle data to ZK ( If the data in memory is not updated, it will not be written to ZK )
3. ......

Modifications

• guarantee step-3 is always executed after step-2
• In this test, the original codes mock ModularLoadManagerWrapper to make isCentralized always return true. But this mock is completely unnecessary because that's ModularLoadManagerWrapper.isCentralized was exactly always returned true, so remove the mock.

Documentation

• doc-required

• doc-not-needed

• doc

• doc-complete

[poorbarcode]

This PR should merge into these branches (because this test was appended in branch-2.11):

• branch-2.11
• master

[codelipenghui]

@heesung-sn Please help review this PR, thanks.

[gaoran10]

It seems the param utilChecker is useless.

[poorbarcode]

That was left over from the previous solution and I forgot to delete it. Already deleted, Thanks

[gaoran10]

Great work! LGTM

[Demogorgon314]

LGTM.

[github-actions]

@poorbarcode Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.

[Technoboy-]

Better to add some comments for line 809~814

[poorbarcode]

Hi @Technoboy-

Better to add some comments for line 809~814

Already add code-comment, thanks

[poorbarcode]

/pulsarbot rerun-failure-checks

[poorbarcode]

/pulsarbot rerun-failure-checks

[poorbarcode]

/pulsarbot rerun-failure-checks

[heesung-sn]

LGTM

[heesung-sn]

  // Wait until "ModularLoadManager" completes processing the ZK notification.
        ModularLoadManagerWrapper modularLoadManagerWrapper = (ModularLoadManagerWrapper) loadManager;
        ModularLoadManagerImpl modularLoadManager = (ModularLoadManagerImpl) modularLoadManagerWrapper.getLoadManager();
        ScheduledExecutorService scheduler = Whitebox.getInternalState(modularLoadManager, "scheduler");

We don't have the scheduler anymore in ModularLoadManagerImpl. I think this test is failing now, caused by #19656