Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][tool] Using int instead of long in python scripts #17215

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

zymap
Copy link
Member

@zymap zymap commented Aug 23, 2022

Motivation

In python3.x, long renamed to int, so we should use int instead
of long in scripts.

Traceback (most recent call last):
File "bin/pulsar-managed-ledger-admin", line 247, in deleteMLLedgerIdsCommand
deletLedgerIdSet.add(long(id))
NameError: name 'long' is not defined

Modifications

  • rename long to int

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

---

*Motivation*

In python3.x, long renamed to int, so we should use int instead
of long in scripts.

*Modification*

- rename long to int
@zymap zymap added type/bug The PR fixed a bug or issue reported a bug area/tool labels Aug 23, 2022
@zymap zymap added this to the 2.12.0 milestone Aug 23, 2022
@zymap zymap self-assigned this Aug 23, 2022
@zymap zymap changed the title [fix][tool] Using int instead of long in python scriptsc [fix][tool] Using int instead of long in python scripts Aug 23, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Aug 23, 2022
@codelipenghui codelipenghui merged commit 8286e8c into apache:master Aug 23, 2022
@Technoboy- Technoboy- modified the milestones: 2.12.0, 2.11.0 Aug 24, 2022
@mattisonchao mattisonchao added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Aug 25, 2022
Jason918 pushed a commit that referenced this pull request Sep 4, 2022
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Sep 16, 2022
(cherry picked from commit 8286e8c)
(cherry picked from commit a0cdf3f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tool cherry-picked/branch-2.9 Archived: 2.9 is end of life cherry-picked/branch-2.10 cherry-picked/branch-2.11 doc-not-needed Your PR changes do not impact docs release/2.9.4 release/2.10.2 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants