[fix][broker] Pass subscriptionName to auth service #17123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
requested review from
merlimat,
lhotari,
eolivelli and
codelipenghui
lhotari
approved these changes
Aug 16, 2022
mattisonchao
approved these changes
Aug 17, 2022
codelipenghui
approved these changes
Aug 17, 2022
Technoboy-
approved these changes
Aug 17, 2022
nodece
approved these changes
Aug 17, 2022
nicoloboschi
approved these changes
Aug 17, 2022
Technoboy-
force-pushed
the
fix-auth-params
branch
from
e437ad2 to
6b4044a
Compare
Technoboy-
pushed a commit
that referenced
this pull request
Aug 19, 2022
|
Hi @michaeljmarshall |
|
Can you help open a new PR to branch-2.10? There are a lot conflict when cherry-pick directly. @michaeljmarshall |
congbobo184
pushed a commit
that referenced
this pull request
Nov 11, 2022
(cherry picked from commit e9c3e21)
congbobo184
pushed a commit
that referenced
this pull request
Dec 7, 2022
(cherry picked from commit e9c3e21)
2 tasks
2 tasks
liangyepianzhou
pushed a commit
that referenced
this pull request
Feb 3, 2023
(cherry picked from commit e9c3e21)
15 tasks
michaeljmarshall
pushed a commit
that referenced
this pull request
Feb 3, 2023
Co-authored-by: Michael Marshall <[email protected]> ### Motivation Cherry-pick #17123 ### Verifying this change - [ ] Make sure that the change passes the CI checks. *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (10MB)* - *Extended integration test for recovery after broker failure* ### Does this pull request potentially affect one of the following parts: <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: <!-- ENTER URL HERE --> <!-- After opening this PR, the build in apache/pulsar will fail and instructions will be provided for opening a PR in the PR author's forked repository. apache/pulsar pull requests should be first tested in your own fork since the apache/pulsar CI based on GitHub Actions has constrained resources and quota. GitHub Actions provides separate quota for pull requests that are executed in a forked repository. The tests will be run in the forked repository until all PR review comments have been handled, the tests pass and the PR is approved by a reviewer. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Pass subscription name to the auth service.
Modifications
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
doc-not-needed