-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][admin] Not allow to terminate system topic. #17006
Conversation
@Technoboy- Please provide a correct documentation label for your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about terminating the partitioned topic?
Not allowed. The logic is here pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java Lines 3686 to 3691 in e1c0ad3
|
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApi2Test.java
Outdated
Show resolved
Hide resolved
ce6493c
to
f945afb
Compare
Fixes #15891
Master Issue: #15891
Motivation
Pulsar-manager could see all the topics including the system topic and can terminate them. If terminates system topic by mistake, there would cause many serious problems. So it's better not allow to terminate the system topic.
Documentation
doc-not-needed
(Please explain why)